Skip to content

feat: add support for entity argument to command converter, use float…#375

Merged
olijeffers0n merged 3 commits into
mainfrom
entity-argument
May 5, 2024
Merged

feat: add support for entity argument to command converter, use float…#375
olijeffers0n merged 3 commits into
mainfrom
entity-argument

Conversation

@MiniDigger
Copy link
Copy Markdown
Member

…ing-ui for select and new autocomplete

@olijeffers0n
Copy link
Copy Markdown
Member

I find it counter intuitive that they change locations, rather than just adding a new box. need other's input here but personally i'm not a fan

@MiniDigger
Copy link
Copy Markdown
Member Author

when I added the autocomplete below it also looked strange 🤷‍♂️
def open to ideas

@kennytv
Copy link
Copy Markdown
Member

kennytv commented May 5, 2024

I'd maybe have the entity type box appear in the middle, so that the mode doesn't move

@olijeffers0n olijeffers0n merged commit 6c06440 into main May 5, 2024
@olijeffers0n olijeffers0n deleted the entity-argument branch May 5, 2024 18:34
@olijeffers0n olijeffers0n self-assigned this May 6, 2024
sowelipililimute pushed a commit to sowelipililimute/docs that referenced this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants