Change xmx/xms ordering#406
Merged
Merged
Conversation
Member
|
This is a valid change, but could you also change them in all the other places |
Contributor
Author
|
Contributor
Author
|
I've made some of the changes here. Let me know if I missed any <3 Thank you! |
powercasgamer
approved these changes
Jun 3, 2024
olijeffers0n
approved these changes
Jun 4, 2024
Member
|
LGTM - Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose that xmx/xms be reordered here (min memory -> max memory as opposed to max memory -> min memory) which makes the overall readability of the script.