Skip to content

fix: correct base URL for Pages deployments#429

Merged
kashike merged 2 commits into
PaperMC:mainfrom
zlataovce:fix/pages-url
Jun 24, 2024
Merged

fix: correct base URL for Pages deployments#429
kashike merged 2 commits into
PaperMC:mainfrom
zlataovce:fix/pages-url

Conversation

@zlataovce
Copy link
Copy Markdown
Member

Fixes broken metadata and makes the sitemap generate once again. To me, it seems like there's no way to get a deployment URL at build time, so this PR tries to guess it for previews.

Based on my observations, deployment URLs are formatted in the https://<id>.papermc-docs.pages.dev format, where <id> is a <PR head branch owner>-<branch name> identifier capped to 28 characters and special characters (/, _, .) replaced with a dash.
Examples:

  • https://papermc-feat-add-trial-chamb.papermc-docs.pages.dev
  • https://zlataovce-fix-highlight-cont.papermc-docs.pages.dev
  • https://papermc-121.papermc-docs.pages.dev

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 22, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview ffe9ac5

@zlataovce zlataovce marked this pull request as draft June 22, 2024 07:54
@zlataovce zlataovce marked this pull request as ready for review June 22, 2024 07:55
@olijeffers0n olijeffers0n requested a review from kashike June 23, 2024 23:06
@kashike kashike self-assigned this Jun 24, 2024
@kashike kashike merged commit 3dc8d81 into PaperMC:main Jun 24, 2024
@zlataovce zlataovce deleted the fix/pages-url branch June 24, 2024 07:50
sowelipililimute pushed a commit to sowelipililimute/docs that referenced this pull request Sep 7, 2025
Adds documentation for the POSS-NOUN Fluent function added by
space-wizards/RobustToolbox#5799.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants