Skip to content

Document methods to resolve issues with Gradle in Groovy#464

Merged
lynxplay merged 4 commits into
PaperMC:mainfrom
minacle:paperweight-userdev
Aug 14, 2024
Merged

Document methods to resolve issues with Gradle in Groovy#464
lynxplay merged 4 commits into
PaperMC:mainfrom
minacle:paperweight-userdev

Conversation

@minacle
Copy link
Copy Markdown
Contributor

@minacle minacle commented Aug 13, 2024

When using paperweight-userdev with Gradle and Groovy syntax instead of Gradle Kotlin DSL, some modifications to the code described in the documentation are necessary.

I have added a note to the documentation regarding the issues I encountered and how to resolve them.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 13, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview 6e7de9d

@lynxplay
Copy link
Copy Markdown
Contributor

Given we don't really provide groovy support anywhere else in the docs (as we heavily favour kotlin) I'd be in favour of making this a bit less verbose.

Something like a general note at the bottom saying that "The static members above are accessed with a get prefix when using the groovy dsl"
Or something along those lines. Generally, just wanna make sure it doesn't look like we actually encourage using groovy.

@minacle
Copy link
Copy Markdown
Contributor Author

minacle commented Aug 13, 2024

How about this?

Comment thread docs/paper/dev/getting-started/userdev.mdx Outdated
@lynxplay
Copy link
Copy Markdown
Contributor

LGTM to me otherwise 👍

minacle and others added 2 commits August 14, 2024 17:56
Co-authored-by: Bjarne Koll <LynxPlay101@gmail.com>
@lynxplay
Copy link
Copy Markdown
Contributor

Thank you!

@lynxplay lynxplay merged commit 1038bf2 into PaperMC:main Aug 14, 2024
sowelipililimute pushed a commit to sowelipililimute/docs that referenced this pull request Sep 7, 2025
Meant to put this here ages ago with the new review procedure but i
forgot.

Basically just mirrors the review procedure section on drafts to the pr
guidelines.

In short
- No draft PRs for incomplete features
- Drafts should only be for PRs that need incremental review

now that we have policy in a consistent place we should enforce it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants