feat: outdated license link and log4j link replacement#595
Merged
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
olijeffers0n
approved these changes
May 19, 2025
olijeffers0n
left a comment
olijeffers0n
left a comment
Member
There was a problem hiding this comment.
Is good, but the table formatting needs fixing please
table format fix
zlataovce
approved these changes
May 20, 2025
zlataovce
left a comment
zlataovce
left a comment
Member
There was a problem hiding this comment.
still needs alignment fixes (see image), I recommend using a Markdown formatter to do it
otherwise LGTM
Contributor
Author
|
will this suffice? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I saw that guava license had been renamed from COPYING 2 years ago so I fixed that, and log4j team links were leading to error pages so I dug around and pulled up the recent pages.