Skip to content

Fixes#75

Merged
Owen1212055 merged 1 commit into
PaperMC:snapshot/25w20afrom
yannicklamprecht:snapshot/25w20a
May 13, 2025
Merged

Fixes#75
Owen1212055 merged 1 commit into
PaperMC:snapshot/25w20afrom
yannicklamprecht:snapshot/25w20a

Conversation

@yannicklamprecht
Copy link
Copy Markdown
Contributor

No description provided.

@Owen1212055
Copy link
Copy Markdown
Member

Thank you for the PR! I was literally working on these and just noticed this pr-- will merge this anyways as our changes are identical.

Wanted to play around with the new dialogue stuff lol.

@Owen1212055 Owen1212055 merged commit 0576241 into PaperMC:snapshot/25w20a May 13, 2025
@yannicklamprecht yannicklamprecht deleted the snapshot/25w20a branch May 13, 2025 22:58
@yannicklamprecht
Copy link
Copy Markdown
Contributor Author

Thank you for the PR! I was literally working on these and just noticed this pr-- will merge this anyways as our changes are identical.

Wanted to play around with the new dialogue stuff lol.

Had time to play around with it as well. Here is my result. Basically changed the logger in MinecraftServer#handleCustomClickAction(...) to log on info.

grafik

Dirty inlineed customization: https://gist.github.com/yannicklamprecht/f22633bc8542f4c36fade5bb41a55571

@Owen1212055
Copy link
Copy Markdown
Member

Thank you for the PR! I was literally working on these and just noticed this pr-- will merge this anyways as our changes are identical.

Wanted to play around with the new dialogue stuff lol.

Had time to play around with it as well. Here is my result. Basically changed the logger in MinecraftServer#handleCustomClickAction(...) to log on info.

grafik

Dirty inlineed customization: https://gist.github.com/yannicklamprecht/f22633bc8542f4c36fade5bb41a55571

Yeah no it's pretty neat. Only thing is that the config stage support is a bit cooked rn but that'll be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants