Add getLastDamageTime method to Combat Tracker API - #13854
Merged
Conversation
Owen1212055
approved these changes
May 3, 2026
Warriorrrr
approved these changes
Jul 28, 2026
papermc-projects
Bot
moved this from Awaiting review
to Delayed approval
in Paper PR Queue
papermc-projects
Bot
moved this from Delayed approval
to Full approval
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a method to get the time since damage was last taken as an extension to the Combat Tracker API.
I decided to calculate the time relative to the entity's tickCount, since the tickCount currently isn't exposed in the API, which would have made the value returned from this new method unfit for further calculations. In most cases, the user would want to calculate the ticks from the current time anyway.
The last damage time could obviously also be calculated using a damage listener, but that would add unnecessary overhead for calculating a value that is already tracked by the server, in my opinion