Skip to content

Update villager prices before opening menu to player - #13906

Merged
Doc94 merged 1 commit into
PaperMC:mainfrom
Doc94:fix/13905-merchant-inventory-api-ignore-reputation-for-villagers
Aug 2, 2026
Merged

Update villager prices before opening menu to player#13906
Doc94 merged 1 commit into
PaperMC:mainfrom
Doc94:fix/13905-merchant-inventory-api-ignore-reputation-for-villagers

Conversation

@Doc94

@Doc94 Doc94 commented May 23, 2026

Copy link
Copy Markdown
Member

Talking in discord about the Villager and the inventory this PR handle a behaviour noticed in #13905 where the methods to open inventory related to Villager ignore the update price for reputation or hero of the village, the only "breaking" change here is if user dont expect to get that change of prices, but just need use https://jd.papermc.io/paper/26.1.2/org/bukkit/inventory/MerchantRecipe.html#setIgnoreDiscounts(boolean) for make clear dont wanna updates in the prices.

Thanks @Y2Kwastaken and @masmc05 for the help with the Inventory behaviour.

Can close #13905

@Doc94
Doc94 requested a review from a team as a code owner May 23, 2026 16:16
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue May 23, 2026
@Doc94 Doc94 added the publish-pr Enables a workflow to build Paperclip jars on the pull request. label May 23, 2026
@papermc-pr-publishing

Copy link
Copy Markdown

Last updated for: 4c74270207b2c9eb6e22e81c2a407f194368c453.

Download the Paperclip jar for this pull request: paper-13906.zip

Maven Publication

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven("https://maven-prs.papermc.io/Paper/pr13906") {
        name = "Maven for PR #13906" // https://github.com/PaperMC/Paper/pull/13906
        mavenContent {
            includeModule("io.papermc.paper", "dev-bundle")
            includeModule("io.papermc.paper", "paper-api")
        }
    }
}

@Doc94 Doc94 moved this from Awaiting review to Full approval in Paper PR Queue Jul 18, 2026
@Doc94 Doc94 changed the title Update Villager Prices before opening inventory to Player using API Update villager prices before opening menu to player Aug 2, 2026
@Doc94
Doc94 force-pushed the fix/13905-merchant-inventory-api-ignore-reputation-for-villagers branch from 4c74270 to 8ef19c6 Compare August 2, 2026 14:36
@Doc94 Doc94 removed the publish-pr Enables a workflow to build Paperclip jars on the pull request. label Aug 2, 2026
@Doc94
Doc94 merged commit b59e472 into PaperMC:main Aug 2, 2026
5 of 6 checks passed
@github-project-automation github-project-automation Bot moved this from Full approval to Merged in Paper PR Queue Aug 2, 2026
@Doc94
Doc94 deleted the fix/13905-merchant-inventory-api-ignore-reputation-for-villagers branch August 2, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

Villager reputation does not apply when opening merchant menu with MenuType.MERCHANT builder

3 participants