Skip to content

--workspace: CWD is not default anymore and is required for V2 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020
Merged

--workspace: CWD is not default anymore and is required for V2 #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gradient/cli/experiments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def common_experiments_create_options(f):
"--workspace",
"workspace",
help="Path to workspace directory, archive, S3 or git repository",
default="none",
cls=common.GradientOption,
),
click.option(
Expand Down
7 changes: 6 additions & 1 deletion gradient/commands/experiments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import six
import terminaltables
from click import style
from halo import halo

from gradient import api_sdk, exceptions, TensorboardClient
from gradient.api_sdk import constants, sdk_exceptions
from gradient.api_sdk.config import config
Expand All @@ -13,7 +15,6 @@
from gradient.commands.common import BaseCommand, ListCommandMixin, DetailsCommandMixin
from gradient.logger import Logger
from gradient.utils import get_terminal_lines, none_strings_to_none_objects
from halo import halo

try:
# Python 3
Expand Down Expand Up @@ -106,6 +107,10 @@ def get_instance_url(self, instance_id, project_id):

def _handle_workspace(self, instance_dict):
handler = self.workspace_handler.handle(instance_dict)

if (instance_dict.get("cluster_id") or instance_dict.get("use_vpc")) and handler.lower() == "none":
raise click.UsageError('Missing option "--workspace" is required for VPC experiments')

instance_dict.pop("ignore_files", None)
instance_dict.pop("workspace", None)
instance_dict.pop("workspace_archive", None)
Expand Down