-
Notifications
You must be signed in to change notification settings - Fork 22
Add secrets #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secrets #278
Conversation
BartoszCki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can skip the one commend I made - I'll have to move tags from BaseClient to a separate mixin anyway and I can remove this line while doing so. It now suggests that all entities can have tags.
|
@BartoszCki and/or @kossak: I noticed the entity stuff was moved into a mixin (#280) so I removed the The API's for this are now available, so if either of you could re-approve I can get this merged. Thanks! P.S. The tests are failing because it looks like the pre-release of numpy uses an f-string in it's setup.py file which fails in the tox python 3.5 tests (python 3.5 isn't supported by numpy anymore, see numpy/numpy#16294). |
mkulaczkowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing
|
@mkulaczkowski Yes, the comment above describes why and they are currently broken on master (see https://github.com/Paperspace/gradient-cli/commits/master). Do want to remove Python 3.5 support (other options include locking version of numpy to <v1.19 or reverting the addition of gradient-utils to the cli)? UPDATE: It looks like numpy was added as a dependency via the addition of gradient-utils to the dependency list in this PR #281 (gradient-utils -> hyperopt -> numpy). The offending version of numpy was v.1.19rc1 which was released 4 days ago (https://github.com/numpy/numpy/releases/tag/v1.19.0rc1). |
This adds secret management for teams, clusters, and projects.
Example usage
NOTE: the APIs to support secrets aren't live yet. We should wait to merge until they are available.