Skip to content

Conversation

@worksewell
Copy link
Contributor

This adds secret management for teams, clusters, and projects.

Example usage

$ gradient secrets set team --name=aws_secret_access_key --value=test
Set team secret 'aws_secret_access_key'

$ gradient secrets list team
+-----------------------+
| Name                  |
+-----------------------+
| aws_secret_access_key |
+-----------------------+

$ gradient secrets delete team --name=aws_secret_access_key
Deleted team secret 'aws_secret_access_key'

NOTE: the APIs to support secrets aren't live yet. We should wait to merge until they are available.

BartoszCki
BartoszCki previously approved these changes May 14, 2020
Copy link
Contributor

@BartoszCki BartoszCki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can skip the one commend I made - I'll have to move tags from BaseClient to a separate mixin anyway and I can remove this line while doing so. It now suggests that all entities can have tags.

kossak
kossak previously approved these changes May 19, 2020
@worksewell
Copy link
Contributor Author

@BartoszCki and/or @kossak: I noticed the entity stuff was moved into a mixin (#280) so I removed the entity = "secret" stuff from SecretsClient and rebased master (only two changes I made)

The API's for this are now available, so if either of you could re-approve I can get this merged.

Thanks!

P.S. The tests are failing because it looks like the pre-release of numpy uses an f-string in it's setup.py file which fails in the tox python 3.5 tests (python 3.5 isn't supported by numpy anymore, see numpy/numpy#16294).

Collecting numpy
 
  Downloading numpy-1.19.0rc1.zip (7.3 MB)
 
  Installing build dependencies: started
 
  Installing build dependencies: finished with status 'done'
 
  Getting requirements to build wheel: started
 
  Getting requirements to build wheel: finished with status 'error'
 
  ERROR: Command errored out with exit status 1:
 
   command: /root/project/.tox/py35-pt46-ptc28/bin/python /root/project/.tox/py35-pt46-ptc28/lib/python3.5/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpv1nkape2
 
       cwd: /tmp/pip-install-x16himj_/numpy
 
  Complete output (19 lines):
 
  Traceback (most recent call last):
 
    File "/root/project/.tox/py35-pt46-ptc28/lib/python3.5/site-packages/pip/_vendor/pep517/_in_process.py", line 280, in <module>
 
      main()
 
    File "/root/project/.tox/py35-pt46-ptc28/lib/python3.5/site-packages/pip/_vendor/pep517/_in_process.py", line 263, in main
 
      json_out['return_val'] = hook(**hook_input['kwargs'])
 
    File "/root/project/.tox/py35-pt46-ptc28/lib/python3.5/site-packages/pip/_vendor/pep517/_in_process.py", line 114, in get_requires_for_build_wheel
 
      return hook(config_settings)
 
    File "/tmp/pip-build-env-0boduin5/overlay/lib/python3.5/site-packages/setuptools/build_meta.py", line 148, in get_requires_for_build_wheel
 
      config_settings, requirements=['wheel'])
 
    File "/tmp/pip-build-env-0boduin5/overlay/lib/python3.5/site-packages/setuptools/build_meta.py", line 128, in _get_build_requires
 
      self.run_setup()
 
    File "/tmp/pip-build-env-0boduin5/overlay/lib/python3.5/site-packages/setuptools/build_meta.py", line 250, in run_setup
 
      self).run_setup(setup_script=setup_script)
 
    File "/tmp/pip-build-env-0boduin5/overlay/lib/python3.5/site-packages/setuptools/build_meta.py", line 143, in run_setup
 
      exec(compile(code, __file__, 'exec'), locals())
 
    File "setup.py", line 182
 
      raise ValueError(f'Submodule {p} missing')
 
                                              ^
 
  SyntaxError: invalid syntax
 
  ----------------------------------------
 
ERROR: Command errored out with exit status 1: /root/project/.tox/py35-pt46-ptc28/bin/python /root/project/.tox/py35-pt46-ptc28/lib/python3.5/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpv1nkape2 Check the logs for full command output.

Copy link
Contributor

@mkulaczkowski mkulaczkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@worksewell
Copy link
Contributor Author

worksewell commented May 22, 2020

@mkulaczkowski Yes, the comment above describes why and they are currently broken on master (see https://github.com/Paperspace/gradient-cli/commits/master).

Do want to remove Python 3.5 support (other options include locking version of numpy to <v1.19 or reverting the addition of gradient-utils to the cli)?

UPDATE: It looks like numpy was added as a dependency via the addition of gradient-utils to the dependency list in this PR #281 (gradient-utils -> hyperopt -> numpy). The offending version of numpy was v.1.19rc1 which was released 4 days ago (https://github.com/numpy/numpy/releases/tag/v1.19.0rc1).

@worksewell worksewell merged commit 094c7ca into master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants