Allow passing URLs and archive paths to --workspace and deprcecate --… #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workspaceUrl and --workspaceArchive
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
====================================
Coverage 80% 80%
====================================
Files 1 1
Lines 10 10
====================================
Hits 8 8
Misses 2 2Continue to review full report at Codecov.
|
kossak
approved these changes
Jul 5, 2019
jaredscheib
reviewed
Jul 9, 2019
| or (workspace_archive and workspace_url) \ | ||
| or (workspace_path and workspace_url): | ||
| raise click.UsageError("Use either:\n\t--workspace https://path.to/git/repository.git - to point repository URL" | ||
| "\n\t--workspace /path/to/local/directory - to point on project directory" |
Contributor
There was a problem hiding this comment.
more naturally this would be something like to point to a project directory or to use a local directory as your workspace :)
jaredscheib
reviewed
Jul 9, 2019
| or (workspace_path and workspace_url): | ||
| raise click.UsageError("Use either:\n\t--workspace https://path.to/git/repository.git - to point repository URL" | ||
| "\n\t--workspace /path/to/local/directory - to point on project directory" | ||
| "\n\t--workspace /path/to/local/archive.zip - to point on project .zip archive" |
Contributor
There was a problem hiding this comment.
more naturally this would be something like to point to a .zip archive or to use a local archive as your workspace :)
BartoszCki
deleted the
PS-10523-deprecate-workspaceUrl-and-workspacePath-and-let-the-workspace-do-their-job
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…workspaceUrl and --workspaceArchive