Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing URLs and archive paths to --workspace and deprcecate --… #34

Conversation

Projects
None yet
3 participants
@BartoszCki
Copy link
Contributor

commented Jul 5, 2019

…workspaceUrl and --workspaceArchive

@BartoszCki BartoszCki requested a review from mkulaczkowski as a code owner Jul 5, 2019

@BartoszCki BartoszCki requested a review from kossak Jul 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 5, 2019

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #34   +/-   ##
====================================
  Coverage      80%   80%           
====================================
  Files           1     1           
  Lines          10    10           
====================================
  Hits            8     8           
  Misses          2     2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e0b8a...ca1aa80. Read the comment docs.

@kossak

kossak approved these changes Jul 5, 2019

@BartoszCki BartoszCki merged commit ffe9ad1 into master Jul 5, 2019

4 checks passed

WIP Ready for review
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e7e0b8a...ca1aa80
Details
codecov/project 80% remains the same compared to e7e0b8a
Details
or (workspace_path and workspace_url):
raise click.UsageError("Use either:\n\t--workspace https://path.to/git/repository.git - to point repository URL"
"\n\t--workspace /path/to/local/directory - to point on project directory"

This comment has been minimized.

Copy link
@jaredscheib

jaredscheib Jul 9, 2019

Contributor

more naturally this would be something like to point to a project directory or to use a local directory as your workspace :)

This comment has been minimized.

Copy link
@BartoszCki

BartoszCki Jul 10, 2019

Author Contributor

PS-10553

This comment has been minimized.

Copy link
@jaredscheib
raise click.UsageError("Use either:\n\t--workspace https://path.to/git/repository.git - to point repository URL"
"\n\t--workspace /path/to/local/directory - to point on project directory"
"\n\t--workspace /path/to/local/archive.zip - to point on project .zip archive"

This comment has been minimized.

Copy link
@jaredscheib

jaredscheib Jul 9, 2019

Contributor

more naturally this would be something like to point to a .zip archive or to use a local archive as your workspace :)

This comment has been minimized.

Copy link
@BartoszCki

BartoszCki Jul 10, 2019

Author Contributor

changed in PS-10553

This comment has been minimized.

Copy link
@jaredscheib

@BartoszCki BartoszCki deleted the PS-10523-deprecate-workspaceUrl-and-workspacePath-and-let-the-workspace-do-their-job branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.