Skip to content

Conversation

@jakob-fritz
Copy link
Collaborator

The previous version of the generated website did not include the plots that were created in the same CI.

Now, the plots are copied into a subdir of the website and are therefore also published, as all content of that directory is used for publication. The links in the RST-files have been updated accordingly.

Therefore updated all links in rst-files to new location of plots
@brownbaerchen
Copy link
Contributor

I like the changes because it makes the paths in the Readmes easier! However, I am not sure if it solves the problem that we're having. The issue is that the plots are not displayed on GitHub because the paths don't lead anywhere in the repository. That is still the case, no? The plots are not persistent in the repository beyond the action, as far as I understand. Since we don't want to check in the plots, I am not sure if what I want is possible, though.

@jakob-fritz
Copy link
Collaborator Author

jakob-fritz commented May 5, 2023

I assume, that it helps, as the plots are now part of the directory that is deployed in the CI. So it should work the same way as it does for the generated html-files that are used for publication.

Therefore, it should also be persistent (i.e. the links should continue to work), as they don't link to the repo, but to another relative location.

It may be seen whether this approach works, when the deploy-job in the current check is executed.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (f2e51e4) 72.62% compared to head (b3a0e6f) 72.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
- Coverage   72.62%   72.60%   -0.03%     
==========================================
  Files         254      254              
  Lines       21089    21089              
==========================================
- Hits        15316    15311       -5     
- Misses       5773     5778       +5     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pancetta pancetta merged commit 1c87d28 into Parallel-in-Time:master May 5, 2023
brownbaerchen added a commit to brownbaerchen/pySDC that referenced this pull request Nov 4, 2025
#!!!!!!!!!! WARNING: RUFF FAILED !!!!!!!!!!: 

#pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:298:5: F841 Local variable `data` is assigned to but never used
#    |
Parallel-in-Time#296 |     res = 32
Parallel-in-Time#297 |
Parallel-in-Time#298 |     data = []
#    |     ^^^^ F841
Parallel-in-Time#299 |     labels = []
Parallel-in-Time#300 |     linestyles = []
#    |
#    = help: Remove assignment to unused variable `data`
#
#pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:299:5: F841 Local variable `labels` is assigned to but never used
#    |
Parallel-in-Time#298 |     data = []
Parallel-in-Time#299 |     labels = []
#    |     ^^^^^^ F841
Parallel-in-Time#300 |     linestyles = []
#    |
#    = help: Remove assignment to unused variable `labels`
#
#pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:300:5: F841 Local variable `linestyles` is assigned to but never used
#    |
Parallel-in-Time#298 |     data = []
Parallel-in-Time#299 |     labels = []
Parallel-in-Time#300 |     linestyles = []
#    |     ^^^^^^^^^^ F841
Parallel-in-Time#301 |
Parallel-in-Time#302 |     ref_data = get_pySDC_data(Ra, res=res, dt=0.01, config_name='RBC3DG4R4')
#    |
#    = help: Remove assignment to unused variable `linestyles`
#
#pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:312:9: F841 Local variable `t` is assigned to but never used
#    |
Parallel-in-Time#310 |         ax.set_title(title)
Parallel-in-Time#311 |         Nu_ref = np.array(ref['Nu']['V'])
Parallel-in-Time#312 |         t = ref['t']
#    |         ^ F841
Parallel-in-Time#313 |
Parallel-in-Time#314 |         for dt in dts:
#    |
#    = help: Remove assignment to unused variable `t`
#
#pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:587:9: E722 Do not use bare `except`
#    |
Parallel-in-Time#585 |                 k[_s > 1e-16], _s[_s > 1e-16], color=last_line.get_color(), ls=last_line.get_linestyle(), label=label
Parallel-in-Time#586 |             )
Parallel-in-Time#587 |         except:
#    |         ^^^^^^ E722
Parallel-in-Time#588 |             pass
#    |
#
#pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:686:5: F841 Local variable `Delta_Nu` is assigned to but never used
#    |
#684 |     t = data['t']
#685 |     avg_Nu = np.array([np.mean(Nu[40 : 40 + i + 1]) for i in range(len(Nu[40:]))])
#686 |     Delta_Nu = np.array([abs(avg_Nu[i + 1] - avg_Nu[i]) for i in range(len(avg_Nu) - 1)])
#    |     ^^^^^^^^ F841
#687 |     # ax.plot(data['t'][40:-1], Delta_Nu / avg_Nu[:-1])
#688 |     # ax.plot(data['t'], np.abs(avg_Nu - avg_Nu[-1]) / avg_Nu[-1])
#    |
#    = help: Remove assignment to unused variable `Delta_Nu`:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants