Fix for the LogWork hook
#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 73.07% 73.07%
=======================================
Files 256 256
Lines 21327 21330 +3
=======================================
+ Hits 15584 15587 +3
Misses 5743 5743
☔ View full report in Codecov by Sentry. |
brownbaerchen
added a commit
to brownbaerchen/pySDC
that referenced
this pull request
Nov 4, 2025
#!!!!!!!!!! WARNING: RUFF FAILED !!!!!!!!!!: #pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:298:5: F841 Local variable `data` is assigned to but never used # | Parallel-in-Time#296 | res = 32 Parallel-in-Time#297 | Parallel-in-Time#298 | data = [] # | ^^^^ F841 Parallel-in-Time#299 | labels = [] Parallel-in-Time#300 | linestyles = [] # | # = help: Remove assignment to unused variable `data` # #pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:299:5: F841 Local variable `labels` is assigned to but never used # | Parallel-in-Time#298 | data = [] Parallel-in-Time#299 | labels = [] # | ^^^^^^ F841 Parallel-in-Time#300 | linestyles = [] # | # = help: Remove assignment to unused variable `labels` # #pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:300:5: F841 Local variable `linestyles` is assigned to but never used # | Parallel-in-Time#298 | data = [] Parallel-in-Time#299 | labels = [] Parallel-in-Time#300 | linestyles = [] # | ^^^^^^^^^^ F841 Parallel-in-Time#301 | Parallel-in-Time#302 | ref_data = get_pySDC_data(Ra, res=res, dt=0.01, config_name='RBC3DG4R4') # | # = help: Remove assignment to unused variable `linestyles` # #pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:312:9: F841 Local variable `t` is assigned to but never used # | Parallel-in-Time#310 | ax.set_title(title) Parallel-in-Time#311 | Nu_ref = np.array(ref['Nu']['V']) Parallel-in-Time#312 | t = ref['t'] # | ^ F841 Parallel-in-Time#313 | Parallel-in-Time#314 | for dt in dts: # | # = help: Remove assignment to unused variable `t` # #pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:587:9: E722 Do not use bare `except` # | Parallel-in-Time#585 | k[_s > 1e-16], _s[_s > 1e-16], color=last_line.get_color(), ls=last_line.get_linestyle(), label=label Parallel-in-Time#586 | ) Parallel-in-Time#587 | except: # | ^^^^^^ E722 Parallel-in-Time#588 | pass # | # #pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:686:5: F841 Local variable `Delta_Nu` is assigned to but never used # | #684 | t = data['t'] #685 | avg_Nu = np.array([np.mean(Nu[40 : 40 + i + 1]) for i in range(len(Nu[40:]))]) #686 | Delta_Nu = np.array([abs(avg_Nu[i + 1] - avg_Nu[i]) for i in range(len(avg_Nu) - 1)]) # | ^^^^^^^^ F841 #687 | # ax.plot(data['t'][40:-1], Delta_Nu / avg_Nu[:-1]) #688 | # ax.plot(data['t'], np.abs(avg_Nu - avg_Nu[-1]) / avg_Nu[-1]) # | # = help: Remove assignment to unused variable `Delta_Nu`:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook records the increment in work counters. However, when doing this in the nonMPI controller with multiple steps, you need to separate the counters for the different "processes". I forgot this because in MPI it is naturally separated and in single step SDC there is also no problem. I wrote a pretty comprehensive test now that checks if the result is actually correct for both MPI and nonMPI versions.