-
Notifications
You must be signed in to change notification settings - Fork 38
Fix CI failures from master merge: pyproject.toml syntax and deprecated test syntax #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
…ansfer, level, step, controller, convergence_controller Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
…vior Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
… controller.py Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add type hinting to core modules
Add type hints to all core modules
Feb 7, 2026
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
…ametrize Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Copilot
AI
changed the title
Add type hints to all core modules
Fix CI failures from master merge: pyproject.toml syntax and deprecated test syntax
Feb 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with master (#611) introduced two breaking issues preventing CI from running.
Changes
pyproject.toml - Fixed TOML syntax error in dev dependencies
dev = [ 'ruff', 'pytest', 'pytest-cov', 'sphinx', - 'mypy' + 'mypy', 'pre-commit' ]Merge conflict left missing comma between 'mypy' (from type hinting branch) and 'pre-commit' (from master), causing parser failure.
tests_core.py - Converted deprecated yield-based parameterization to
@pytest.mark.parametrizeApplied to
test_errors,test_datatypes_mesh, andtest_datatypes_particles. Removed now-unnecessary helper functions.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.