Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 7, 2026

Merge with master (#611) introduced two breaking issues preventing CI from running.

Changes

pyproject.toml - Fixed TOML syntax error in dev dependencies

 dev = [
     'ruff',
     'pytest',
     'pytest-cov',
     'sphinx',
-    'mypy'
+    'mypy',
     'pre-commit'
 ]

Merge conflict left missing comma between 'mypy' (from type hinting branch) and 'pre-commit' (from master), causing parser failure.

tests_core.py - Converted deprecated yield-based parameterization to @pytest.mark.parametrize

# Before (pytest <5.0 syntax, now removed)
def test_errors():
    classes = ['DataError']
    for subclass in classes:
        yield check_error, subclass

# After (modern pytest)
@pytest.mark.parametrize('subclass', ['DataError'])
def test_errors(subclass):
    import pySDC.core.errors
    err = getattr(pySDC.core.errors, subclass)
    try:
        raise err('bla')
    except err:
        assert True

Applied to test_errors, test_datatypes_mesh, and test_datatypes_particles. Removed now-unnecessary helper functions.

Original prompt

This section details on the original issue you should resolve

<issue_title>Type hinting</issue_title>
<issue_description>There are currently no type hints in core modules (or anywhere, for that matter). How hard would it be to add and test those comprehensively?</issue_description>

<agent_instructions>Run the CI test suite before finishing work to make sure everything works</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 12 commits February 7, 2026 15:31
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
…ansfer, level, step, controller, convergence_controller

Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
…vior

Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
… controller.py

Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Copilot AI changed the title [WIP] Add type hinting to core modules Add type hints to all core modules Feb 7, 2026
Copilot AI requested a review from pancetta February 7, 2026 15:59
Copilot AI and others added 2 commits February 8, 2026 11:00
Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
…ametrize

Co-authored-by: pancetta <7158893+pancetta@users.noreply.github.com>
Copilot AI changed the title Add type hints to all core modules Fix CI failures from master merge: pyproject.toml syntax and deprecated test syntax Feb 8, 2026
@pancetta pancetta marked this pull request as ready for review February 8, 2026 11:31
@pancetta pancetta merged commit 1a8f640 into master Feb 8, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type hinting

3 participants