Release 2.15 requires ssh2-python=>1.2.0 but not specified in setup.py

[jefverschuerend09]

For general questions please use the mail group.

Describe the bug
setup.py needs to be updated to install at least ssh2-python
currently it's mentioned in release notes but no minimum version is specified
installation doesn't overwrite already installed versions like 1.0.0

To Reproduce

1. Have system with ssh2-python < 1.2.0
2. Install latest version of parallelssh
3. ssh2-python is not updated
4. parallelssh fails

Expected behavior
ssh2-python is updated along with parallel-ssh

Actual behaviour
dependency ssh2-python remained at old version

Screenshots
N/A

Additional information

"Requirement already satisfied: requests>=2.19.1 in /usr/lib/python3.9/site-packages (from -r /runner/project/automation/../library/requirements.txt (line 1)) (2.25.0)",
"Collecting parallel-ssh>=2.13.0",
" Downloading parallel_ssh-2.16.0-py3-none-any.whl (88 kB)",
"Requirement already satisfied: chardet<4,>=3.0.2 in /usr/lib/python3.9/site-packages (from requests>=2.19.1->-r /runner/project/automation/../library/requirements.txt (line 1)) (3.0.4)",
"Requirement already satisfied: idna<3,>=2.5 in /usr/lib/python3.9/site-packages (from requests>=2.19.1->-r /runner/project/automation/../library/requirements.txt (line 1)) (2.10)",
"Requirement already satisfied: urllib3<1.27,>=1.21.1 in /usr/lib/python3.9/site-packages (from requests>=2.19.1->-r /runner/project/automation/../library/requirements.txt (line 1)) (1.25.10)",
"Requirement already satisfied: ssh2-python in /usr/local/lib64/python3.9/site-packages (from parallel-ssh>=2.13.0->-r /runner/project/automation/../library/requirements.txt (line 2)) (1.0.0)",
"Requirement already satisfied: ssh-python in /usr/local/lib64/python3.9/site-packages (from parallel-ssh>=2.13.0->-r /runner/project/automation/../library/requirements.txt (line 2)) (1.0.0)",
"Requirement already satisfied: gevent in /usr/local/lib64/python3.9/site-packages (from parallel-ssh>=2.13.0->-r /runner/project/automation/../library/requirements.txt (line 2)) (24.11.1)",
"Requirement already satisfied: zope.interface in /usr/local/lib64/python3.9/site-packages (from gevent->parallel-ssh>=2.13.0->-r /runner/project/automation/../library/requirements.txt (line 2)) (7.1.1)",
"Requirement already satisfied: greenlet>=3.1.1; platform_python_implementation == "CPython" in /usr/local/lib64/python3.9/site-packages (from gevent->parallel-ssh>=2.13.0->-r /runner/project/automation/../library/requirements.txt (line 2)) (3.1.1)",
"Requirement already satisfied: zope.event in /usr/local/lib/python3.9/site-packages (from gevent->parallel-ssh>=2.13.0->-r /runner/project/automation/../library/requirements.txt (line 2)) (5.0)",
"Requirement already satisfied: setuptools in /usr/lib/python3.9/site-packages (from zope.interface->gevent->parallel-ssh>=2.13.0->-r /runner/project/automation/../library/requirements.txt (line 2)) (50.3.2)",
"Installing collected packages: parallel-ssh",
"Successfully installed parallel-ssh-2.16.0"

[jefverschuerend09]

I'm not a package maintainer but assume minimum versions should be listed here?

parallel-ssh/setup.py

Line 40 in 38d14ee

'gevent', 'ssh2-python', 'ssh-python'],

[pkittenis]

Thanks for the interest.

Minimum versions are defined in requirements.txt which is used by pip for installing.

ssh2-python>=1.2.0
ssh-python>=1.2.0

How are you installing this without pip.

[jefverschuerend09]

It's being installed with pip. setup.py is used by setuptools (as far as I know...) and also lists requirements as I linked. Those need to be updated as well.

[jefverschuerend09]

I've gone ahead and made a PR

[pkittenis]

Do you have example installation with pip that does not install correct requirements?

Pip installation seems to install correct requirements, as below.

$ pip install parallel-ssh
Collecting parallel-ssh
  Downloading parallel_ssh-2.16.0-py3-none-any.whl.metadata (11 kB)
Collecting gevent (from parallel-ssh)
  Using cached gevent-25.9.1-cp312-cp312-manylinux2014_x86_64.manylinux_2_17_x86_64.whl.metadata (14 kB)
Collecting ssh2-python (from parallel-ssh)
  Downloading ssh2_python-1.2.0.post1-cp312-cp312-manylinux2014_x86_64.manylinux_2_17_x86_64.whl.metadata (5.6 kB)
Collecting ssh-python (from parallel-ssh)
  Downloading ssh_python-1.2.0.post1-cp312-cp312-manylinux2014_x86_64.manylinux_2_17_x86_64.whl.metadata (4.0 kB)
Collecting greenlet>=3.2.2 (from gevent->parallel-ssh)
  Using cached greenlet-3.2.4-cp312-cp312-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl.metadata (4.1 kB)
Collecting zope.event (from gevent->parallel-ssh)
  Downloading zope_event-6.0-py3-none-any.whl.metadata (5.1 kB)
Collecting zope.interface (from gevent->parallel-ssh)
  Downloading zope_interface-8.0.1-cp312-cp312-manylinux1_x86_64.manylinux2014_x86_64.manylinux_2_17_x86_64.manylinux_2_5_x86_64.whl.metadata (44 kB)
Collecting setuptools>=75.8.2 (from zope.event->gevent->parallel-ssh)
  Using cached setuptools-80.9.0-py3-none-any.whl.metadata (6.6 kB)
Downloading parallel_ssh-2.16.0-py3-none-any.whl (88 kB)
Using cached gevent-25.9.1-cp312-cp312-manylinux2014_x86_64.manylinux_2_17_x86_64.whl (2.1 MB)
Using cached greenlet-3.2.4-cp312-cp312-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl (607 kB)
Downloading ssh_python-1.2.0.post1-cp312-cp312-manylinux2014_x86_64.manylinux_2_17_x86_64.whl (3.4 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.4/3.4 MB 10.0 MB/s  0:00:00
Downloading ssh2_python-1.2.0.post1-cp312-cp312-manylinux2014_x86_64.manylinux_2_17_x86_64.whl (5.1 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.1/5.1 MB 10.5 MB/s  0:00:00
Downloading zope_event-6.0-py3-none-any.whl (6.4 kB)
Using cached setuptools-80.9.0-py3-none-any.whl (1.2 MB)
Downloading zope_interface-8.0.1-cp312-cp312-manylinux1_x86_64.manylinux2014_x86_64.manylinux_2_17_x86_64.manylinux_2_5_x86_64.whl (264 kB)
Installing collected packages: ssh2-python, ssh-python, zope.interface, setuptools, greenlet, zope.event, gevent, parallel-ssh
Successfully installed gevent-25.9.1 greenlet-3.2.4 parallel-ssh-2.16.0 setuptools-80.9.0 ssh-python-1.2.0.post1 ssh2-python-1.2.0.post1 zope.event-6.0 zope.interface-8.0.1

[pkittenis]

Thanks for the report.

2.16.0.post1 resolves.

See Minimal Reproducible Example on creating minimal reproducible example instructions.