This repository was archived by the owner on Jul 4, 2025. It is now read-only.
Conversation
a-hacker
force-pushed
the
reactify-user-settings
branch
from
5e9b7c9 to
d0b4c5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework user settings to not rely on soy templates except for the bare minimum (like project and global jenkins settings).
Also utilitize rest endpoints for token updates. This removes batch save functionality in favor of individual save methods.
Finally, added test settings buttons for each token. This was easy enough due to react state storing the whole server definition for each jenkins server.