Support migrated resources with different password requirements #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvyBongers
commented
Jan 4, 2022
roles.tf
Outdated
|
|
||
| length = 48 | ||
| special = false | ||
| special = var.password_special_chars |
Contributor
Author
There was a problem hiding this comment.
Possible alternative to prevent changes when migrating resources:
Suggested change
| special = var.password_special_chars | |
| special = false | |
| lifecycle { | |
| ignore_changes = [special] | |
| } |
Contributor
There was a problem hiding this comment.
I think I like the alternative more. Can always be tainted when a new password is needed after all.
Contributor
There was a problem hiding this comment.
Would probably add the other "modifiers" as well.
Contributor
Author
There was a problem hiding this comment.
Any particular reason to add them? Other than being explicit about all of them
Contributor
There was a problem hiding this comment.
That and a little bit of "better safe than sorry". Might save us some follow-up PRs adding one or more others down the road. Might slightly ease the migration routes. If it's worth it, no idea 😉
tun0
approved these changes
Jan 4, 2022
EvyBongers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.