Refactor how _datasets.structured.generic handles constants#2007
Merged
VeckoTheGecko merged 2 commits intov4-devfrom May 27, 2025
Merged
Refactor how _datasets.structured.generic handles constants#2007VeckoTheGecko merged 2 commits intov4-devfrom
_datasets.structured.generic handles constants#2007VeckoTheGecko merged 2 commits intov4-devfrom
Conversation
VeckoTheGecko
force-pushed
the
2004-refactorings
branch
from
e033aad to
f0beca8
Compare
VeckoTheGecko
force-pushed
the
2004-refactorings
branch
from
f0beca8 to
bad0828
Compare
Contributor
Author
|
v4 test failures unrelated (due to grid adapter - idk if that's still relevant to the current codebase). Will fix in another PR. Test started failing in 8c143a5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4-devfor v4 changes)Also patched a couple failing tests and added another.