Skip to content

2010 generic unstructured dataset#2016

Merged
fluidnumericsJoe merged 4 commits intov4-devfrom
2010-generic-unstructured-dataset
Jun 3, 2025
Merged

2010 generic unstructured dataset#2016
fluidnumericsJoe merged 4 commits intov4-devfrom
2010-generic-unstructured-dataset

Conversation

@fluidnumericsJoe
Copy link
Copy Markdown
Contributor

This PR adds a new unstructured grid generic dataset resembling FESOM. A test has been included in tests/v4, but it is marked to be skipped since there are some correctness issues in the _search_time_indices function that cause it to fail.

Copy link
Copy Markdown
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Happy to merge

Just a note that it may be useful at some point in future to add a time dimension to these datasets (similar to what is done in structured.generic) where we defined T=13 and then do a xr.date_range("2000", "2001", T).

@fluidnumericsJoe
Copy link
Copy Markdown
Contributor Author

These do have a time dimension ("time"). the thinking here is to provide a dataarray that would be consistent with what we get from loading a FESOM dataset in UxArray.

At any rate, I see your point. Could you open an issue describing the change you want to see ? That way we can get it knocked out in some of the "finishing/polishing" work and not forget this.

@fluidnumericsJoe fluidnumericsJoe merged commit de835f5 into v4-dev Jun 3, 2025
3 of 9 checks passed
@fluidnumericsJoe fluidnumericsJoe deleted the 2010-generic-unstructured-dataset branch June 3, 2025 13:46
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Parcels development Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants