Feature/from icon #2454
Open
Feature/from icon #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`zc` refers to the vertical center and `zf` refers to the vertical interface I've also relaxed the requirement that the Conventions attribute be defined; having this convention defined in the uxdataarray doesn't imply compliance with a given convention..
New interpolator naming convention for unstructured grids will follow Ux<lateral type><face|node|edge><vertical type><ZF | ZC> where lateral type is the type of interpolation applied in the lateral directions (e.g. "Constant" or "Linear") and vertical type is the type of interpolation applied in the vertical direction . The choice of face, node, or edge indicates where data is registered laterally and the choice of ZF or ZC indicates where data is registered vertically.
Still sorting out an issue with the linear node constant z interpolator
for more information, see https://pre-commit.ci
Also adjusted the test function for barycentric interpolation to an affine function of lat and lon (f=a*lon + b*lat); Affine functions are exact for barycentric interpolation while product (f=a*lon*lat) are not exact since the second derivative (the leading truncation error) is non-zero.
Signed areas in 2-D help ensure that we don't have false positives. Since uxarray ensures consistent winding direction among elements, this is a safe change to make that also helps prevent edge cases of finding points in a cell that are not actually in the cell.
…nto feature/from_icon
…efinitions of other included interpolators
…nto feature/from_icon
I suspect a library under the hood (a uxarray dependency) changed causing a change in the output of the delaunay triangulation. Note that delaunay triangulations are not unique (there is more than one possible triangulation possible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
FieldSet.from_iconto support easy loading of data from the ICON model. Resolves #2425In the process of adding this support, the following additional changes were made
Ux<lateral type><face|node|edge><vertical type><ZF | ZC>where<lateral type>is the type of interpolation applied in the lateral directions (e.g. "Constant" or "Linear") and<vertical type>is the type of interpolation applied in the vertical direction . The choice offace,node, oredgeindicates where data is registered laterally and the choice ofZForZCindicates where data is registered vertically.