Merged
Conversation
Adding an ErrorCode that break the pset.execute() loop, as requested in #779
CKehl
approved these changes
Apr 1, 2020
Contributor
CKehl
left a comment
CKehl
left a comment
There was a problem hiding this comment.
Yes, nice short-and-simple integration of the functionality request in #779 . Personally, I still would prefer to shift the stopping flag due to it's function, because all the codes after 'Error' are actually ErrorCodes while all flugs up to 'Error' are more status flags. But that is up to your liking to change it or leave it. Functionally, it all looks good.
this fixes some of @CKehl 's review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an ErrorCode that break the pset.execute() loop, as requested in #779.
To use, add the following to a Kernel