Argo drift time must be less than cycle time#345
Merged
Conversation
erikvansebille
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a model validation step to the
ArgoFloatConfigensuring that the drift time is always less than the cycle time.New test added which ensures errors are thrown when the invalid configuration (drift time > cycle time or drift time == cycle_time) is used.
Closes #157
It could be worth considering moving some of these validation checks to the Instrument classes themselves (rather than the Pydantic models), to make those more self-contained and portable for more Pythonic use of instruments... but I think that refactoring would follow in a future PR (i.e. #346)