Add GenerateUnpickData task#27
Merged
sciwhiz12 merged 2 commits intoParchmentMC:devfrom Jan 20, 2025
Merged
Conversation
|
|
Member
|
What is the end goal here? |
Contributor
Author
|
The goal is to publish unpick files with Parchment. It is more convenient to develop unpick files separately but it's nice to bundle them into one when publishing. This is what Yarn does, and Parchment already does this with mappings. There is no technical reason it has to be done this way. |
sciwhiz12
requested changes
Jan 20, 2025
Member
sciwhiz12
left a comment
sciwhiz12
left a comment
There was a problem hiding this comment.
Looks generally fine, just one minor quibble about the use of try-catch versus method throws declaration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only modification to Compass required to start shipping unpick data with Parchment