Skip to content

Fixed miscellaneous typos. #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lanse505 merged 1 commit into from
Jun 27, 2025
Merged

Fixed miscellaneous typos. #329

Lanse505 merged 1 commit into from
Jun 27, 2025

Conversation

@WestonJB
Copy link
Contributor

@WestonJB WestonJB commented Apr 28, 2025 •
edited
Loading

As per mapping guidelines, no methods or class names were changed (although there were many typos there as well).
This PR addresses #328

@WestonJB WestonJB requested a review from a team as a code owner April 28, 2025 23:37
@CLAassistant
Copy link

CLAassistant commented Apr 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@WestonJB WestonJB closed this Apr 28, 2025
@WestonJB WestonJB reopened this Apr 28, 2025
@PiTheGuy PiTheGuy linked an issue May 25, 2025 that may be closed by this pull request
PlayerTabOverlay#visible javadoc typo #328
Closed
@Lanse505 Lanse505 added enhancement Change to the code or other non-mappings files needs rebase Needs to be rebased to resolve merge conflicts 1.21.x For Minecraft 1.21.x bug An error, misspell, incorrect information, or other issue mappings Changes to the mapping data and removed enhancement Change to the code or other non-mappings files labels Jun 26, 2025
@Lanse505
Copy link
Member

Lanse505 commented Jun 26, 2025

The big 1.21.6 update got merged ahead of this, please rebase upon the new commit and I'll review this as fast as I can to get it merged.

@WestonJB WestonJB closed this Jun 26, 2025
@WestonJB WestonJB reopened this Jun 26, 2025
Lanse505
Lanse505 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@Lanse505 Lanse505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@WestonJB WestonJB requested a review from Lanse505 June 26, 2025 13:07
@Lanse505
Copy link
Member

Lanse505 commented Jun 26, 2025

I'll leave this up for 24 hours, if no objections are raised, then I'll merge this ^^

@sciwhiz12 sciwhiz12 removed the needs rebase Needs to be rebased to resolve merge conflicts label Jun 26, 2025
@Lanse505 Lanse505 merged commit 0acd178 into ParchmentMC:versions/1.21.x Jun 27, 2025
3 checks passed
PiTheGuy pushed a commit to PiTheGuy/Parchment that referenced this pull request Jul 17, 2025
@WestonJB @PiTheGuy
Fixed miscellaneous typos. (ParchmentMC#329)
fa8fce9
PiTheGuy pushed a commit to PiTheGuy/Parchment that referenced this pull request Jul 18, 2025
@WestonJB @PiTheGuy
Fixed miscellaneous typos. (ParchmentMC#329)
31dc604
jpenilla pushed a commit to PaperMC/ParchmentMappings that referenced this pull request Sep 19, 2025
@WestonJB @jpenilla
Fixed miscellaneous typos. (ParchmentMC#329)
6626524
jpenilla pushed a commit to PaperMC/ParchmentMappings that referenced this pull request Sep 23, 2025
@WestonJB @jpenilla
Fixed miscellaneous typos. (ParchmentMC#329)
6233970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sciwhiz12 sciwhiz12 sciwhiz12 approved these changes

@Lanse505 Lanse505 Awaiting requested review from Lanse505

Assignees

No one assigned

Labels

1.21.x For Minecraft 1.21.x bug An error, misspell, incorrect information, or other issue mappings Changes to the mapping data

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PlayerTabOverlay#visible javadoc typo

4 participants

@WestonJB @CLAassistant @Lanse505 @sciwhiz12