fix: force lockdir on windows to be user dir#371
Merged
Conversation
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
dz0ny
force-pushed
the
fix/lock-location
branch
from
3e0fe0b to
4c7d698
Compare
zupo
reviewed
Sep 17, 2025
|
|
||
| lockFile, err := singleinstance.CreateLockFile("paretosecurity-tray.lock") | ||
| // Ensure lock directory exists | ||
| lockFile, err := singleinstance.CreateLockFile(filepath.Join(lockDir, ".paretosecurity-tray.lock")) |
Member
There was a problem hiding this comment.
I'm gonna assume this file is hidden from user, as I am afraid if it is not, someone will trash it.
Member
Author
There was a problem hiding this comment.
Hidden yes. On windows, this defaults to home folder, which is actually not seen by the users.
zupo
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/teamniteo/pareto/issues/807