Conversation
zupo
force-pushed
the
fix/win_version
branch
from
a40216c to
7f42c99
Compare
zupo
changed the title
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
dz0ny
reviewed
Sep 18, 2025
Windows 11 reports itself as Windows 10 to maintain compatibility with legacy applications. We have to look into `buildNumber` to differentiate between Windows 10 and Windows 11. Ref: teamniteo/pareto#800
zupo
force-pushed
the
fix/win_version
branch
from
7f42c99 to
221dc66
Compare
zupo
changed the title
dz0ny
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows 11 reports itself as Windows 10 to maintain compatibility with legacy applications. We have to look into
buildNumberto differentiate between Windows 10 and Windows 11.Refs https://github.com/teamniteo/pareto/issues/811