fix: Add tests for screensaver and power settings with localization#482
Merged
fix: Add tests for screensaver and power settings with localization#482
Conversation
Member
dz0ny
commented
Jan 28, 2026
dz0ny
commented
- Add more detailed reasons for check failures on Windows.
- Remove hibernation from consideration in ScreensaverTimeout check.
…upport - Add more detailed reasons for check failures on Windows. - Remove hibernation from consideration in ScreensaverTimeout check.
🚀 Dev Builds AvailableDevelopment builds for this PR are available in the workflow artifacts. Available builds:
Download the |
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR significantly improves Windows screensaver and power settings checks by adding comprehensive test coverage, supporting localized Windows output, and providing more detailed failure messages.
Changes:
- Added extensive test coverage for screensaver timeout and password checks with 18 new test cases covering desktop, laptop, localized Windows, and modern Windows scenarios
- Refactored screensaver timeout check to use
powercfgfor display timeouts instead of relying solely on screensaver settings, with detailed failure messages for AC/DC power states - Enhanced password check to support modern Windows where CONSOLELOCK is not exposed, with fallback to lock screen detection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| checks/windows/screensaver_password_test.go | Added 18 comprehensive test cases with sample powercfg output including Slovenian localization, tests for display timeout, screensaver timeout, and password protection scenarios for both desktop and laptop configurations |
| checks/windows/screensaver_password.go | Refactored to check display power settings via powercfg, added battery detection using Get-CimInstance, implemented regex-based parsing for localized output, added modern Windows fallback for CONSOLELOCK, and provided detailed status messages for different failure scenarios |
…etween integer types Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.