Fix file upload bug: inverted condition prevented files from being saved#4
Merged
inventionpro merged 1 commit intoParley-Chat:mainfrom Feb 22, 2026
Merged
Conversation
The condition in sending_messages() required content_length > max_file_size AND chunked_size <= max_file_size simultaneously, which is impossible. This caused files to never be saved, resulting in blank messages. Fixed by simplifying to: file exists AND size <= max_file_size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Sending files (encrypted or not) weren't being saved and blank messages were sent.
Root Cause
In , the condition for processing file uploads had inverted logic:
This required (file too big) AND (file within limits) simultaneously. This is impossible to satisfy, so files were never processed.
Fix
Simplified the condition to check if the file exists and is within size limits:
Testing
Files should now be properly saved and messages with attachments will include the attachment data instead of appearing blank.