Add Rosylyn analyzer for irrelevant APIs#717
Merged
Conversation
Contributor
jpalac
commented
Sep 8, 2023
jpalac
commented
- Rebase of [SPIKE] Api usage analyzer spike #640
- Fixes Prevent the use of NSB configuration APIs that aren't applicable to serverless environments #651
timbussmann
reviewed
Sep 12, 2023
Contributor
timbussmann
left a comment
timbussmann
left a comment
There was a problem hiding this comment.
Looks solid to me. I added a few thoughts about the diagnostic messages (sorry for not making better suggestions right away).
| internal static readonly DiagnosticDescriptor MaxAutoLockRenewalDurationNotAllowed = new DiagnosticDescriptor( | ||
| id: MaxAutoLockRenewalDurationNotAllowedId, | ||
| title: "MaxAutoLockRenewalDuration is not supported in Azure Functions", | ||
| messageFormat: "Azure Functions endpoints do not control the message receiver and cannot decide the lock renewal duration.", |
Contributor
There was a problem hiding this comment.
should we refer to the trigger specific config option instead? https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-service-bus-trigger?tabs=python-v2%2Cin-process%2Cnodejs-v4%2Cextensionv5&pivots=programming-language-csharp#peeklock-behavior
Contributor
Author
|
Thank you @timbussmann and @danielmarbach for taking the time to look over this PR. |
mikeminutillo
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.