Add support for the Azure Service Bus emulator running on default ports#1334
Add support for the Azure Service Bus emulator running on default ports#1334danielmarbach merged 1 commit intomasterfrom
Conversation
jpalac
left a comment
There was a problem hiding this comment.
Code looks fine, tests make sense - assume it works :-)
Do we need a CI test for this so that we know when it breaks? Especially if we are looking to put this into our docs.
How about a first imperfect step to say in the docs something like "The emulator will work with NServiceBus with these restrictions .... However, Particular does not officially support it, and we encourage the use of Azure Service Bus instead." |
|
|
||
| public bool SetupInfrastructure { get; init; } | ||
|
|
||
| internal int MaxDeliveryCount { get; init; } = int.MaxValue; |
There was a problem hiding this comment.
isn't this always set externally? If so, having the default value seems to be lying about the intent
There was a problem hiding this comment.
I figured there was a chance that it would get created in another place later and it would get missed. I did consider making it required but that felt like a code smell with an internal member on a public class. This way, the worst case is that the emulator is affected, but Azure Service Bus connections are not.
198a152 to
c70dd96
Compare
Passed! - Failed: 0, Passed: 3, Skipped: 0, Total: 3, Duration: 37 s - They ran |
Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com> Co-authored-by: Yngve Bakken-Nilsen <yngve.nilsen@gmail.com>
19f1799 to
69b2f64
Compare
This pull request is based on this pull request and allows NServiceBus to use the Azure Service Bus emulator to create queues, topics, and subscriptions. The emulator is still limited to 10 connections, as detailed here, but it now exposes the Azure Service Bus Management API to allow on-the-fly changes.
Related to #1104