Persistence tests leave saga storage directories around in temp directory#7771
Merged
danielmarbach merged 1 commit intoMay 26, 2026
Conversation
Delete saga storage directory in persistence tests Cleanup PersistenceTestsConfiguration.Configure created saga storage under %TEMP%\.sagas\<TestID> but Cleanup was a no-op, so every persistence test run leaked its directory and they accumulated indefinitely. Track the storage location and recursively delete it in Cleanup
danielmarbach
approved these changes
May 26, 2026
danielmarbach
changed the title
DavidBoike
pushed a commit
that referenced
this pull request
May 27, 2026
* Delete saga storage directory in persistence tests Cleanup (#7771) Delete saga storage directory in persistence tests Cleanup PersistenceTestsConfiguration.Configure created saga storage under %TEMP%\.sagas\<TestID> but Cleanup was a no-op, so every persistence test run leaked its directory and they accumulated indefinitely. Track the storage location and recursively delete it in Cleanup * Update dependency PolySharp to 1.16.0 (#7772) Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com> * Fix NSB0033 false positive for Handle methods implementing a derived IHandleMessages (#7770) * Fix NSB0033 false positive for Handle methods implementing a derived IHandleMessages Fix NSB0033 false positive for Handle methods implementing a derived IHandleMessages<T> interface The mixed-style check treated any Handle(message, context, ...) method with more than two parameters as convention-based, even when that method is the implementation of an interface member. This produced a false positive for handlers that implement a custom interface deriving from IHandleMessages<T> which exposes an extended Handle signature (e.g. an extra CancellationToken) backed by a default interface method that forwards to the two-parameter IHandleMessages<T>.Handle. IsValidConventionBasedHandleMethod now classifies a Handle method that implements any interface member as interface-based rather than convention-based, regardless of parameter count. * Add test to verify NSB0033 does not report false positive for derived handler interfaces * Update handler validation to support custom interface implementation types and introduce sensible fast path checks * Regression test * Fix discover of handler interface methods --------- Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com> * Fix string append method in PipelineStepDiagnostics This causes a warning when compiled using .NET 11 Preview 4. * Mark source-generated handler adapters with CompilerGeneratedAttribute (#7778) * Add CompilerGenerated attribute to generated handlers * Align attribute qualifying * Hide the other source gen only methods * Emit GeneratedCodeAttribute to generated infrastructure classes and methods --------- Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com> --------- Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com> Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com> Co-authored-by: John Simons <john.simons@particular.net>
Member
|
Changing from Bug to Improvement given that it does not affect the shipped component. |
This was referenced May 27, 2026
SimonCropp
deleted the
Delete-saga-storage-directory-in-persistence-tests-Cleanup
branch
This was referenced May 27, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete saga storage directory in persistence tests Cleanup PersistenceTestsConfiguration.Configure created saga storage under %TEMP%.sagas<TestID> but Cleanup was a no-op, so every persistence test run leaked its directory and they accumulated indefinitely. Track the storage location and recursively delete it in Cleanup