Messages relating to endpoints should contain the endpoint info inside the message

[SimonCropp]

The message body should include the full intent of the message.

So in the case if ReportCustomCheckResult and EndpointHeartbeat the endpoint information should be contained within the message

[dannycohen]

@SimonCropp - Sounds like tight-coupling of the message payload with the routing data. Isn't this an RPC 'feature' ?

[andreasohlund]

I agree with @SimonCropp , lets fix this

[johnsimons]

Is this really required for v1?

[dannycohen]

@johnsimons - Thinking about it:

1. We are adding host process information to the endpoint, assuming that there may be cases where more than one endpoint instance will be located on the same machine
2. If that is correct, and I do not add an endpoint instance identification to the messages themselves, how will I be able to identify which endpoint instance sent which message ?
   • (a by-question is why would I want to do that, but I see several reasons; let me know if you wish to discuss this as well)

[andreasohlund]

We've already added this info to 4.4 messages. I've also added a mutator in the plugin so that anyone with the heartbeats on will have that info as well regardless of nsb version. (Still in a pull req)

Does this align?

Sent from my iPhone

On 9 feb 2014, at 08:02, Danny Cohen notifications@github.com wrote:

@johnsimons - Thinking about it:

We are adding host process information to the endpoint, assuming that there may be cases where more than one endpoint instance will be located on the same machine
If that is correct, and I do not add an endpoint instance identification to the messages themselves, how will I be able to identify which endpoint instance sent which message ?
(a by-question is why would I want to do that, but I see several reasons; let me know if you wish to discuss this as well)
—
Reply to this email directly or view it on GitHub.

[johnsimons]

Fixed as part of #196