Add API to report disconnected endpoint count to ServiceControl.Monitoring#2059
Merged
WilliamBZA merged 2 commits intomasterfrom Aug 11, 2020
Merged
Add API to report disconnected endpoint count to ServiceControl.Monitoring#2059WilliamBZA merged 2 commits intomasterfrom
WilliamBZA merged 2 commits intomasterfrom
Conversation
Co-authored-by: Helen Tsai <helenktsai@gmail.com>
WilliamBZA
approved these changes
Jul 24, 2020
Member
|
Don't forget milestones and labels |
Member
|
I've added to the 4.12.0 release. |
boblangley
commented
Aug 12, 2020
|
|
||
| return context.SecondInstance; | ||
| })) | ||
| .Done(async c => |
Member
Author
There was a problem hiding this comment.
Remember this is run over and over until it returns true.
boblangley
commented
Aug 12, 2020
Comment on lines
+82
to
+84
| Assert.AreEqual(0, context.AfterAllStartedCount, "Disconnected count after all endpoints started"); | ||
| Assert.AreEqual(1, context.AfterFirstStoppedCount, "Disconnected count after first endpoint stopped"); | ||
| Assert.AreEqual(2, context.AfterSecondStoppedCount, "Disconnected count after both endpoints stopped"); |
Member
Author
There was a problem hiding this comment.
Are asserts are incorrect, but I think the rest of the test is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new API and test to report the total endpoint disconnected count for use by ServicePulse.