Skip to content

Conversation

@ramonsmits
Copy link
Member

No description provided.

@ramonsmits ramonsmits self-assigned this Apr 7, 2021
@ramonsmits ramonsmits requested a review from HEskandari April 8, 2021 07:15
@SzymonPobiega
Copy link
Member

Folks, please if possible delay merging this PR until we're done with the enhancement release because we are working on the same area (SC performance) and we fear that we might step into each other's toes.

We also think it is a potentially very dangerous change for some customers as we don't know how many people have SC instances with stale indexes running in the wild and now showing severe enough symptoms that would justify raising a support case.

@ramonsmits
Copy link
Member Author

@SzymonPobiega A healthy instance should have no issues. This should not delay a healthy startup much.

I'll also tweak the message that stale indexes are "normal".

{
text.AppendLine($"- Index [{indexError.IndexName}] error: {indexError.Error} (Action: {indexError.Action}, Doc: {indexError.Document}, At: {indexError.Timestamp})");
}
throw new Exception(text.ToString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consider creating a specific exception? Something like "RavenDBHasStaleIndexes"?

@ramonsmits
Copy link
Member Author

Closing this in favor of #2478 which contains the changes from this PR.

@ramonsmits ramonsmits closed this Apr 12, 2021
johnsimons added a commit that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants