-
Notifications
You must be signed in to change notification settings - Fork 48
Check for RavenDB index errors and delay start until no stale indexes #2485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for RavenDB index errors and delay start until no stale indexes #2485
Conversation
|
Folks, please if possible delay merging this PR until we're done with the enhancement release because we are working on the same area (SC performance) and we fear that we might step into each other's toes. We also think it is a potentially very dangerous change for some customers as we don't know how many people have SC instances with stale indexes running in the wild and now showing severe enough symptoms that would justify raising a support case. |
|
@SzymonPobiega A healthy instance should have no issues. This should not delay a healthy startup much. I'll also tweak the message that stale indexes are "normal". |
| { | ||
| text.AppendLine($"- Index [{indexError.IndexName}] error: {indexError.Error} (Action: {indexError.Action}, Doc: {indexError.Document}, At: {indexError.Timestamp})"); | ||
| } | ||
| throw new Exception(text.ToString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we consider creating a specific exception? Something like "RavenDBHasStaleIndexes"?
|
Closing this in favor of #2478 which contains the changes from this PR. |
…Frontend/typescript-eslint-8.35.0
No description provided.