Skip to content

Report total folder size as MB, GB, or TB #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2021
Merged

Report total folder size as MB, GB, or TB #2487

merged 4 commits into from
Apr 7, 2021

Conversation

@ramonsmits
Copy link
Member

@ramonsmits ramonsmits commented Apr 7, 2021 •
edited by danielmarbach
Loading

Alternative to #2480 to report the sizes as MB, GB, or TB.

ByteSize 2.0.0 license is MIT

Example of startup info:

-------------------------------------------------------------
ServiceControl Version:             4.17.0-report-foldersize-humanize.1+56.Branch.report-foldersize-humanize.Sha.0a74daee389ee6283d319f77c56b69916b6534fa
Audit Retention Period (optional):
Error Retention Period:             10.00:00:00
Ingest Error Messages:              True
Forwarding Error Messages:          False
Database Size:                      1.05 MB
Database Folder Size:               119.93 MB
ServiceControl Logging Level:       Info
RavenDB Logging Level:              Warn
Selected Transport Customization:   ServiceControl.Transports.Learning.LearningTransportCustomization, ServiceControl.Transports.Learning
-------------------------------------------------------------

@ramonsmits ramonsmits changed the title Folder size Report total folder size as MB, GB, or TB Apr 7, 2021
@ramonsmits ramonsmits mentioned this pull request Apr 7, 2021
Closed
danielmarbach
danielmarbach reviewed Apr 7, 2021
View reviewed changes
@ramonsmits ramonsmits force-pushed the report-foldersize-humanize branch from d090b38 to ed4976a Compare April 7, 2021 12:29
danielmarbach
danielmarbach approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@danielmarbach danielmarbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment LGTM

@danielmarbach
Copy link
Contributor

danielmarbach commented Apr 7, 2021

Given that Humanizer uses MIT License and seems to still be fairly active I think it would be OK to take a dependency on it.

@ramonsmits ramonsmits marked this pull request as ready for review April 7, 2021 13:37
@ramonsmits
Copy link
Member Author

ramonsmits commented Apr 7, 2021

@danielmarbach Replaces the package with a smaller one. We could also instead just copy that file into the solution instead of taking a package dependency.

@danielmarbach danielmarbach added this to the 4.17.0 milestone Apr 7, 2021
danielmarbach
danielmarbach reviewed Apr 7, 2021
View reviewed changes
Copy link
Contributor

@danielmarbach danielmarbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I saw the output I think there is little value in presenting the bytes

@danielmarbach danielmarbach merged commit 789d282 into master Apr 7, 2021
@danielmarbach danielmarbach deleted the report-foldersize-humanize branch April 7, 2021 20:23
johnsimons added a commit that referenced this pull request Nov 20, 2025
@johnsimons
Merge pull request #2487 from Particular/dependabot/npm_and_yarn/src/…
ec1eae1 
…Frontend/prettier-3.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielmarbach danielmarbach danielmarbach approved these changes

Assignees

No one assigned

Labels

Improvement

Projects

None yet

Milestone

4.17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ramonsmits @danielmarbach