Exposed a MessageFailed event for external integrations

[SzymonPobiega]

WIP
Moved MessageFailed, ExceptionDetails and FailureDetails contracts back to internal namespace and created an empty/placeholder MessageFailed public contracts.

[andreasohlund]

Shouldn't this throw or return false to cause us to retry?

If not we might not send the event out?

[SzymonPobiega]

Implemented review actions: added HearbeatRestored event, renamed Reference class.

[Bishbulb]

This doesn't seem to be fully implemented. Failed messages from ServiceControl 1.3.0 are still being published with the internal message contract instead of the message contract from the ServiceControl.Contracts NuGet package.

When can we expect to see ServiceControl publishing events using the contract that is defined in ServiceControl.Contracts?

[andreasohlund]

Could it be old subscriptions for the internal events?

[Bishbulb]

@andreasohlund Looks like that was the reason why I was still receiving the old message type.

However, I'm still unable to get the subscription working for the new message type. This is how I have things configured in my custom failed message NServiceBus handler:

<UnicastBusConfig>
    <MessageEndpointMappings>
      <add Assembly="ServiceControl.Contracts" Endpoint="Particular.ServiceControl" />
    </MessageEndpointMappings>
  </UnicastBusConfig>

When I startup this handler, I don't see any new subscriptions getting added to RavenDB at http://localhost:33333/storage. I've tried manually adding a subscription, but still nothing gets delivered on a failed message.

Thoughts?

[seanfarmar]

I tried it locally and get the subscription pulled, but like @Bishbulb not seeing anything in Raven and my subscriber is not getting any events...

I'm using CS 1.3.0 and ServiceControl.Contracts 1.0.0 package

[Bishbulb]

@sfarmar When you say that you get the subscription pulled, what do you mean by that?

I'm also on SC 1.3.0 and using the ServiceControl.Contracts 1.0.0 package.

[andreasohlund]

Just double checking:

• Json serialization is selected
• You've included "ServiceControl.Contracts" in your conventions

[Bishbulb]

@andreasohlund Json was on, but I was missing the convention to mark ServiceControl.Contracts as an event --> adding that has fixed the issue for me. Thanks for the tip!

[seanfarmar]

yup, i'm running the sample i ran in NYC, i have json serielizer and the conventions set, but no luck :-|

[Bishbulb]

@sfarmar Check the installation directory for SC at C:\Program Files (x86)\Particular Software\ServiceControl. In my case the ServiceControl.Contracts.dll/pdb files were not present in that directory. I had to do a full uninstall/reinstall of ServiceControl in order to get things working.

I had previously upgraded from SC 1.2.0 to 1.3.0 by using Chocolatey cup ServiceControl.install which appears to have left things in a bad state. I used Chocolatey to upgrade SC to 1.3.0 on three different machines and each one had this same problem.

What ended up working for me was to uninstall SC (choco uninstall ServiceControl.install) and then reinstall (choco install ServiceControl.install).

[Bishbulb]

I just repro'ed the issue with the ServiceControl upgrade via Chocolatey. I had a server that was on SC 1.2.3 and ran cup ServiceControl.install. Everything completed without errors and now I can see that the ServiceControl.Contracts.dll/pdb files are missing in the install directory.

[seanfarmar]

👍 that was the issue, uninstalled - reinstalled and it works! cheers @Bishbulb

[andreasohlund]

Thanks @Bishbulb , new issue raised to track the upgrade issue #395