Report saga audit misconfigurations more prominently #4523
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceControl 5 stopped ingesting saga audit messages in the primary/error instance, and instead began forwarding them to the audit instance as a workaround. The original intent was to remove this forwarding in the next major version.
However, removing that capability gains very little in terms of code to maintain or coupling, and instead would make saga audits sent to the wrong place result in a cryptic deserialization exception and a message in the ServiceControl error queue that is difficult to remedy.
Instead, this PR embraces the self-healing aspect of the forwarding strategy, while raising the log message from a warning to an error, and making it more prominent by surfacing the problem as a custom check that would be visible within ServicePulse.