Skip to content

Conversation

@DavidBoike
Copy link
Member

@DavidBoike DavidBoike commented Oct 10, 2024

ServiceControl 5 stopped ingesting saga audit messages in the primary/error instance, and instead began forwarding them to the audit instance as a workaround. The original intent was to remove this forwarding in the next major version.

However, removing that capability gains very little in terms of code to maintain or coupling, and instead would make saga audits sent to the wrong place result in a cryptic deserialization exception and a message in the ServiceControl error queue that is difficult to remedy.

Instead, this PR embraces the self-healing aspect of the forwarding strategy, while raising the log message from a warning to an error, and making it more prominent by surfacing the problem as a custom check that would be visible within ServicePulse.

@DavidBoike DavidBoike self-assigned this Oct 10, 2024
@DavidBoike DavidBoike added this to the 6.0.0 milestone Oct 10, 2024
@bording bording merged commit ce2c5ef into master Oct 17, 2024
@bording bording deleted the sagaaudit-forward branch October 17, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants