Add average labels to monitoring sparklines and graphs #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquirosj
commented
Jul 7, 2022
src/ServicePulse.Host/app/modules/monitoring/js/directives/ui.particular.largeGraph.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@sergioc this first version is working for the large graph. I would like to pair for implementing the same on the smaller graphs. I also have some concerns about the browser features I used that I would like to review with you. |
cquirosj
changed the title
cquirosj
force-pushed
the
avg-labels
branch
2 times, most recently
from
bf16de6 to
c623f0f
Compare
cquirosj
changed the title
Contributor
Author
|
@sergioc could you test the average label in /monitoring/views/monitored_endpoints_list_grouped.html? I couldn't switch to the grouped view. |
sergioc
changed the title
In the monitoring module, when hovering a given graph, show the corresponding average value on a label outside the sparkline.
- matching graph color - smaller size - fixing positioning bug when window content is scrolled
- average label added to small graphs - average label function moved to its own file - passing new required attributes to everywhere small graphs are used: endpoint details, monitored endpoints list, monitored endpoint list grouped - css improvements for showing all the text inside the label aligned to the left and to make the suffix unit of measure to be a bit smaller than the displaying average value
sergioc
approved these changes
Jul 14, 2022
WojcikMike
approved these changes
Jul 14, 2022
WilliamBZA
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Adding average labels to graphs in monitoring module In the monitoring module, when hovering a given graph, show the corresponding average value on a label outside the sparkline. * avg label improvements - matching graph color - smaller size - fixing positioning bug when window content is scrolled * adding mesurement unit * average label for small graphs - average label added to small graphs - average label function moved to its own file - passing new required attributes to everywhere small graphs are used: endpoint details, monitored endpoints list, monitored endpoint list grouped - css improvements for showing all the text inside the label aligned to the left and to make the suffix unit of measure to be a bit smaller than the displaying average value * avg label styling improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the average value of a metric on a label outside a hovered monitoring sparkline or graph.