Removing .js from imports #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeminutillo
approved these changes
Feb 5, 2024
PhilBastian
approved these changes
Feb 5, 2024
| if (type == "array" || type == "object") { | ||
| for (let i in obj) { | ||
| for (const i in obj) { |
Contributor
There was a problem hiding this comment.
terrible variable name... I suggest key
Member
Author
There was a problem hiding this comment.
we can address this in a different PR
| } | ||
| const data = await response.json(); | ||
| var message = data; | ||
| const message = data; |
Contributor
There was a problem hiding this comment.
I know this isn't new... but why?
| } catch (err) { | ||
| console.log(err); | ||
| var result_1 = { | ||
| const result_1 = { |
Contributor
There was a problem hiding this comment.
i suspect this was from Mike using autoconvert to async await: can we just have this object returned rather than having a machine generated variable name?
| } catch (err) { | ||
| console.log(err); | ||
| var result_1 = { | ||
| const result_1 = { |
| } catch (err) { | ||
| console.log(err); | ||
| var result_1 = { | ||
| const result_1 = { |
Member
Author
There was a problem hiding this comment.
I think there is an eslint about this, "unnecessary variable", can you check @PhilBastian ?
| } catch (err) { | ||
| console.log(err); | ||
| var result_1 = { | ||
| const result_1 = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a few files, but is just removing the
.jsfrom the imports, so that once we rename the files to.tswe don't need to revisit these imports.