Failed messages to typescript #1769

cquirosj · 2024-03-05T18:50:06Z

Migrated all components in the failed messages area to TypeScript and remedy multiple minor issues in this area

Will probably need to move MessageHeader interface to a separate file and may need to break it up into multiple types

johnsimons

A few comments so far

src/ServicePulse.Host/vue/tsconfig.app.json

src/ServicePulse.Host/vue/tsconfig.node.json

src/ServicePulse.Host/vue/vite.config.ts

src/ServicePulse.Host/vue/vitest.config.ts

src/ServicePulse.Host/vue/src/components/failedmessages/AllDeletedMessages.vue

This reverts commit 20ce2fc.

src/ServicePulse.Host/vue/src/resources/FailedMessageView.ts

src/ServicePulse.Host/vue/src/resources/Message.ts

src/ServicePulse.Host/vue/src/components/failedmessages/MessageList.vue

src/ServicePulse.Host/vue/src/components/failedmessages/MessageView.vue

src/ServicePulse.Host/vue/src/components/failedmessages/AllDeletedMessages.vue

src/ServicePulse.Host/vue/src/components/failedmessages/LastTenOperations.vue

src/ServicePulse.Host/vue/src/components/failedmessages/MessageView.vue

… possible

…etedMessages.vue Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>

…nOperations.vue Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>

…eView.vue Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>

* Convert EditRetryDialog to Typescript * Add the optional chaining operator back into the template * Update emit to typescript * Fixing errors after rebase * Update src/ServicePulse.Host/vue/src/components/failedmessages/EditRetryDialog.vue Co-authored-by: John Simons <john.simons@particular.net> * fixing v-for loop --------- Co-authored-by: Christian <christian.quiros+github@gmail.com> Co-authored-by: Christian <christian.quiros@particular.net> Co-authored-by: John Simons <john.simons@particular.net>

src/ServicePulse.Host/vue/tsconfig.node.json

src/ServicePulse.Host/vue/vitest.config.ts

src/ServicePulse.Host/vue/vite.config.ts

…MessageGroups.vue Co-authored-by: Travis Nickels <travis.nickels@particular.net>

migrate AllFailedMessages control to typescript

cquirosj · 2024-03-13T21:54:30Z

@cquirosj As part of this PR, there should not be a need to modify either vite.config.ts or tsconfig.*.ts at all, are there any issues you are having building the project?

All changes made to config.ts files have been reverted.

src/ServicePulse.Host/vue/tsconfig.app.json

johnsimons · 2024-03-13T22:12:40Z

src/ServicePulse.Host/vue/src/components/failedmessages/AllDeletedMessages.vue

-  const response = await useFetchFromServiceControl(`archive/groups/id/${groupId}`);
-  const data = await response.json();
+async function loadGroupDetails(groupId: string) {
+  const [, data] = await useTypedFetchFromServiceControl<FailureGroup>(`archive/groups/id/${groupId}`);


Unfortunately it may be too late, but it would be nice for all the URLs to be typed from routeLinks

src/ServicePulse.Host/vue/src/components/failedmessages/AllDeletedMessages.vue

…r/ServicePulse into failed-messages-to-vue

cquirosj added 5 commits March 5, 2024 17:42

addressing __dirname vue-tsc --build error

0fd5686

CSP correct casing for headers type in vite.config

a0b8dd4

fixes to tsconfig files

586616b

LastTenOperations.vue to TS

65fd741

Introducing RecoverabilityHistoryResponse interface

136864b

cquirosj force-pushed the failed-messages-to-vue branch from b751e09 to 136864b Compare March 5, 2024 23:42

mikeminutillo and others added 4 commits March 6, 2024 18:08

Migrate EditMessageHeader to TypeScript

b127e1e

Will probably need to move MessageHeader interface to a separate file and may need to break it up into multiple types

removing not needed emptying of array

466554a

AllDeletedMessages.vue migrated

b8930f6

FailedMessagesView.vue

09f5bb1

johnsimons requested changes Mar 6, 2024

View reviewed changes

cquirosj and others added 7 commits March 6, 2024 17:51

non required null guard in AllDeletedMessages

20ce2fc

MessageView.vue migrated to TS

b792e39

Revert "non required null guard in AllDeletedMessages"

9db51db

This reverts commit 20ce2fc.

MessageView.vue making ref nuable

a0e170c

removing union type usage for groupId

316bb97

Migrate FailedMessageGroupNoteEdit to TypeScript

85f9275

convert messagelist to typescript

647cee5

PhilBastian reviewed Mar 7, 2024

View reviewed changes

PhilBastian and others added 9 commits March 7, 2024 14:30

cleanup failedmessagestatus usage to be lowercase, and use enum where…

55b9c19

… possible

Update src/ServicePulse.Host/vue/src/components/failedmessages/AllDel…

fa4b2ca

…etedMessages.vue Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>

Update src/ServicePulse.Host/vue/src/components/failedmessages/LastTe…

03191c1

…nOperations.vue Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>

Addressing some of the suggestions from PR review

e9673fd

Introduce Failure group type

7dc48ea

Update src/ServicePulse.Host/vue/src/components/failedmessages/Messag…

82730ad

…eView.vue Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>

Getting rid of Ref (with capital R) from "vue"

6cc50e0

Revert "moduleResolution" to "Bundler"

1553ada

johnsimons requested changes Mar 7, 2024

View reviewed changes

src/ServicePulse.Host/vue/tsconfig.node.json Outdated Show resolved Hide resolved

src/ServicePulse.Host/vue/vitest.config.ts Outdated Show resolved Hide resolved

src/ServicePulse.Host/vue/vite.config.ts Show resolved Hide resolved

PhilBastian and others added 8 commits March 12, 2024 15:47

migrate pending retries control to typescript (#1776)

1ed9260

Update src/ServicePulse.Host/vue/src/components/failedmessages/Failed…

7a73998

…MessageGroups.vue Co-authored-by: Travis Nickels <travis.nickels@particular.net>

fix build

495f260

Merge pull request #1775 from Particular/allfailed_to_typescript

926df7b

migrate AllFailedMessages control to typescript

fix some styling to better match legacy angular pages

2bf6e55

address review comments

4fc4be3

Addressing PR review-reverting changes to config

2354f62

set allowJs to false

941dcf3

johnsimons reviewed Mar 13, 2024

View reviewed changes

src/ServicePulse.Host/vue/tsconfig.app.json Outdated Show resolved Hide resolved

johnsimons reviewed Mar 13, 2024

View reviewed changes

src/ServicePulse.Host/vue/src/components/failedmessages/AllDeletedMessages.vue Show resolved Hide resolved

cquirosj and others added 7 commits March 13, 2024 16:24

reverting all changes to config files

490d50b

remove redundant check

7091ad7

Removing magic strings for NServiceBusHeaders

8527ab2

replace string checks for success

853c6eb

Merge branch 'failed-messages-to-vue' of https://github.com/Particula…

51a196c

…r/ServicePulse into failed-messages-to-vue

type group statuses

2c65fc2

fix logic around what defines a retry

c87b35f

cquirosj marked this pull request as ready for review March 14, 2024 01:35

PhilBastian requested a review from johnsimons March 14, 2024 01:44

johnsimons approved these changes Mar 14, 2024

View reviewed changes

cquirosj merged commit 0b0ff37 into master Mar 14, 2024

cquirosj deleted the failed-messages-to-vue branch March 14, 2024 02:03

PhilBastian assigned mikeminutillo, cquirosj, TravisNickels and PhilBastian Mar 14, 2024

cquirosj modified the milestones: vNext, 1.38.2 Mar 20, 2024

Failed messages to typescript #1769

Failed messages to typescript #1769

Uh oh!

Conversation

cquirosj commented Mar 5, 2024 • edited by PhilBastian Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnsimons left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cquirosj commented Mar 13, 2024

Uh oh!

Uh oh!

johnsimons Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cquirosj commented Mar 5, 2024 •

edited by PhilBastian

Loading