Skip to content

Conversation

@PhilBastian
Copy link
Contributor

I've included a few checklist items that I think are good for reviewers to check for. Feel free to suggest others, but they shouldn't be too onerous or be wishful thinking for things which aren't true already (e.g. I intentionally didn't include a checkbox for "any added or changed code is covered by tests")

Copy link
Contributor

@cquirosj cquirosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a solid first version. In a future iteration, it could be helpful to add an item to the checklist pointing to guidance on when to use “composables” vs plain utility functions; for example, explaining that composables typically follow the use naming convention and leverage Vue’s composition-API (reactivity, lifecycle hooks, etc.), whereas a regular utility should remain a simple, stateless function intended purely to avoid duplication.

Copy link
Member

@johnsimons johnsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PhilBastian PhilBastian merged commit 262c1e2 into master Nov 30, 2025
5 checks passed
@PhilBastian PhilBastian deleted the pr_template branch November 30, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants