Adding an icon indicating lost connection to sc monitoring #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojcikMike
force-pushed
the
add_failed_connection_icon
branch
from
b7ded6f to
8afd196
Compare
WilliamBZA
reviewed
Dec 11, 2017
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
Member
There was a problem hiding this comment.
This file needs to be added to the csproj file. I think the release build might break unless this is included in the csproj
WilliamBZA
reviewed
Dec 11, 2017
| default_route: '/dashboard', | ||
| service_control_url: 'http://localhost:33333/api/', | ||
| monitoring_urls: ['http://localhost:33633/'] | ||
| service_control_url: 'http://localhost:33533/api/', |
Contributor
There was a problem hiding this comment.
No reason in particular, will revert when not WIP anymore.
WilliamBZA
reviewed
Dec 11, 2017
| } | ||
|
|
||
| .pa-monitoring-lost { | ||
| background-image: url('../img/monitoring-lost.svg'); |
Member
There was a problem hiding this comment.
As per our debug session, we'll need 2 rules here depending on the path
sergioc
changed the title
WojcikMike
force-pushed
the
add_failed_connection_icon
branch
from
b8efd06 to
3c07026
Compare
Contributor
Author
|
Ready to be reviewed and merged |
WilliamBZA
approved these changes
Dec 14, 2017
Member
WilliamBZA
left a comment
WilliamBZA
left a comment
There was a problem hiding this comment.
Needs a milestone. Is it going with 1.9.2?
Contributor
|
Latest version is 1.11.0, so make milestone 1.12.0? |
sergioc
suggested changes
Dec 14, 2017
Contributor
sergioc
left a comment
sergioc
left a comment
There was a problem hiding this comment.
I need to re-adjust the failed msgs icon
sergioc
changed the title
sergioc
changed the title
sergioc
approved these changes
Dec 19, 2017
WilliamBZA
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Adding an icon indicating lost connection to sc monitoring * Revised connectivity issue indicators * Revised empty state and use internal doco search link * Fixing issue with the icons * Making the sc monitoring connection failure toast to show only once * Making the error for failed sc monitoring connection to show only once * Adding code to support multiple sc monitoring * new icons for different statuses and markup clean up * Place uknown data indicators before units in overview * Fixing icons to show on details page * Changing the text displayed in toast notifications * Fixing hiding of units when there is no connection * Hiding units whent SC monitoring is discuonnected * remove the default parameter for the functionality to work in IE 11. * Manual merge ;) * Fix icon layout and add CSS truncating to object names * Tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sergioc I finished it from my end. The icons are added. I marked it as WIp to allow you to do what you need to do