Skip to content

Adding retry button on one message #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2018
Merged

Adding retry button on one message #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86bea3b
Adding retry button on one message
WojcikMike Nov 2, 2018
ee57c9e
Position retry btn
sergioc Nov 2, 2018
c678856
Showing the button only on hover
WojcikMike Nov 5, 2018
67c81af
Changing the message to more generic
WojcikMike Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ServicePulse.Host/app/css/particular.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,12 +596,20 @@ p.metadata {
margin-bottom: 6px;
}

p.metadata button {
position: absolute;
right: -35px;
top: 26px;
}

span.metadata {
display: inline-block;
padding: 0px 20px 2px 0;
color: #777f7f;
}



.metadata:first-child {
padding-left: 0;
}
Expand Down
21 changes: 21 additions & 0 deletions src/ServicePulse.Host/app/js/views/failed_messages/controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,27 @@
vm.loadMoreResults(vm.selectedExceptionGroup);
};

vm.viewMessage = function (message) {
$location.path(`/failed-messages/message/${message.id}`);
};

vm.retryMessage = function(message, $event) {
toastService.showInfo("Message retry requested");
serviceControlService.retryFailedMessages([message.id])
.then(function() {
var indexOfMessage = vm.selectedIds.indexOf(message.id);
if (indexOfMessage) {
vm.selectedIds.splice(indexOfMessage, 1);
}

vm.failedMessages = vm.failedMessages.filter(function(item) {
return item.id !== message.id;
});
}
);
$event.stopPropagation();
};

vm.clipComplete = function(messageId) {
toastService.showInfo(messageId + ' copied to clipboard');
};
Expand Down
44 changes: 22 additions & 22 deletions src/ServicePulse.Host/app/js/views/failed_messages/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,32 +67,32 @@ <h3 class="active group-title group-message-count">{{vm.selectedExceptionGroup.c
<multi-checkboxlist messages="vm.failedMessages" selected-ids="vm.selectedIds" message="message" multiselection="vm.multiselection"></multi-checkboxlist>

<div class="col-xs-11 failed-message-data" ng-mouseenter="message.hover2 = true" ng-mouseleave="message.hover2 = false">
<a href="#/failed-messages/message/{{message.id}}">

<div class="row" ng-class="{rowSelected: message.selected == true}" ng-click="vm.viewMessage(message)">
<div class="col-sm-12">
<div class="row box-header">
<div class="col-sm-12 no-side-padding">
<p class="lead break" ng-class="{'msg-type-hover': message.hover2}">{{message.message_type || 'Message Type Unknown - missing metadata EnclosedMessageTypes'}}</p>
<p class="metadata">
<span ng-if="message.retried" tooltip="Message is being retried" class="label sidebar-label label-info metadata-label">Retried</span>
<span ng-if="message.archived" tooltip="Message is being archived" class="label sidebar-label label-warning metadata-label">Archived</span>
<span ng-if="message.number_of_processing_attempts > 1" tooltip="This message has already failed {{message.number_of_processing_attempts}} times" class="label sidebar-label label-important metadata-label">{{message.number_of_processing_attempts}} Retry Failures</span>

<span class="metadata"><i class="fa fa-clock-o"></i> Failed: <sp-moment date="{{message.time_of_failure}}"></sp-moment></span>
<span class="metadata"><i class="fa pa-endpoint"></i> Endpoint: {{message.receiving_endpoint.name}}</span>
<span class="metadata"><i class="fa fa-laptop"></i> Machine: {{message.receiving_endpoint.host}}</span>
<span class="metadata" ng-show="message.redirect"><i class="fa pa-redirect-source pa-redirect-small"></i> Redirect: {{message.redirect}}</span>
<button type="button" class="btn btn-link btn-sm" ng-click="vm.retryMessage(message, $event)" ng-hide="!message.hover2" >
<i aria-hidden="true" class="fa fa-repeat no-link-underline">&nbsp</i>Request retry
</button>
</p>

<pre class="stacktrace-preview" isolate-click ng-show="message.panel === 0">{{ message.exception.message }}</pre>

<div class="row" ng-class="{rowSelected: message.selected == true}">

<div class="col-sm-12">
<div class="row box-header">
<div class="col-sm-12 no-side-padding">
<p class="lead break" ng-class="{'msg-type-hover': message.hover2}">{{message.message_type || 'Message Type Unknown - missing metadata EnclosedMessageTypes'}}</p>
<p class="metadata">
<span ng-if="message.retried" tooltip="Message is being retried" class="label sidebar-label label-info metadata-label">Retried</span>
<span ng-if="message.archived" tooltip="Message is being archived" class="label sidebar-label label-warning metadata-label">Archived</span>
<span ng-if="message.number_of_processing_attempts > 1" tooltip="This message has already failed {{message.number_of_processing_attempts}} times" class="label sidebar-label label-important metadata-label">{{message.number_of_processing_attempts}} Retry Failures</span>

<span class="metadata"><i class="fa fa-clock-o"></i> Failed: <sp-moment date="{{message.time_of_failure}}"></sp-moment></span>
<span class="metadata"><i class="fa pa-endpoint"></i> Endpoint: {{message.receiving_endpoint.name}}</span>
<span class="metadata"><i class="fa fa-laptop"></i> Machine: {{message.receiving_endpoint.host}}</span>
<span class="metadata" ng-show="message.redirect"><i class="fa pa-redirect-source pa-redirect-small"></i> Redirect: {{message.redirect}}</span>
</p>

<pre class="stacktrace-preview" isolate-click ng-show="message.panel === 0">{{ message.exception.message }}</pre>

</div>
</div>
</div>
</div>
</a>
</div>
</div>
</div>

Expand Down