Adding retry button on one message #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergioc
suggested changes
Nov 2, 2018
Contributor
sergioc
left a comment
sergioc
left a comment
There was a problem hiding this comment.
Repositioned button.
The only thing left to do is to only show the button when hovering the row for a given message.
WilliamBZA
reviewed
Nov 2, 2018
Member
WilliamBZA
left a comment
WilliamBZA
left a comment
There was a problem hiding this comment.
Code is 👌, UI looks busy to me, but I don't tend to think about things like that. Perhaps the only show on hover will solve that.
| }; | ||
|
|
||
| vm.retryMessage = function(message, $event) { | ||
| toastService.showInfo("Retrying the message " + message.id + " ..."); |
Member
There was a problem hiding this comment.
Does the message id mean anything to the user? Is there a better value we can show here @sergioc ?
Contributor
There was a problem hiding this comment.
There's no value in specifying message ID in the toast notification since that's the only message you're retrying. A generic message would suffice. Suggestion:
Message retry requested
Contributor
Author
|
I've hidden the button and show it only on hover. Till now It was disabled unless the row is hovered, now it is hidden. |
Contributor
Author
|
Message is changed, @sergioc please approve so that I can merge this. |
sergioc
approved these changes
Nov 5, 2018
WojcikMike
pushed a commit
that referenced
this pull request
Nov 26, 2018
* Remove not needed dates in the large graph, and fix the scaleX when first series holds no values and second series does. * Fixing typo (#662) * Add tab to url (#666) * Adding information about which tab should be open to URL * Adding no data message when there is no messages processed (#667) * Making 0 line on graph always show (#668) * Min width 1440px (#669) * force min-width to 1440px * remove unnecessary !important * Change from s to sec for clarity (#670) * Change monitoring url (#671) * Change monitoring url from monitoring_endpoints -> monitoring * Fixing details url to /monitoring/endpoint/ * Adding retry button on one message (#672) * Adding retry button on one message * Position retry btn * Showing the button only on hover * Changing the message to more generic * Filtering out system messages (#674) * Filtering out system messages * Applying coloring to units of graphed values (#673) * Applying coloring to units of graphed values * Adjust value and unit colors * Change hour abbreviation to hr * wraping custom check text (#683) * Add storing of group by in URL (#682) * Adding a toolbar that contains SC connectivity status (#677) * Adding a toolbar that contains information about connectivity to SC and SC Monitoring * footer stick to bottom and layout tweaking * further footer tweaks * remove version indicator from dashboard * Improve footer contrast * reverting changes to constant * Adding the connecting state to the toolbar * Changing to show toast errors once for connection error * Adding a code to check connectivity to SC Monitoring * Update src/ServicePulse.Host/app/modules/monitoring/js/directives/ui.particular.monitoringConnectivityStatus.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net> * Update src/ServicePulse.Host/app/modules/monitoring/js/services/services.monitoring.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net> * Change the method name, remove iterating through array * Rename vars * Sp installer con test buttons (#685) * test button for sc * check sc connectivity on button click * Show message boxes after sc connectivity check * connectivity check for sc monitoring * apply review fixes * more fixes * remove connectivity check from feature dlg next action * detect existing sp instance port (#678) * Fixing the bottom line to always show, and don't vanish (#687) * Pre release fixes (#686) * fix 1440px width in footer * Shrink heartbeats toggling warning * Emphasise connected status text * Fix tab focus indicator padding * changing styles a not depend on angular thingies * Bump version to 1.15
WilliamBZA
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Remove not needed dates in the large graph, and fix the scaleX when first series holds no values and second series does. * Fixing typo (#662) * Add tab to url (#666) * Adding information about which tab should be open to URL * Adding no data message when there is no messages processed (#667) * Making 0 line on graph always show (#668) * Min width 1440px (#669) * force min-width to 1440px * remove unnecessary !important * Change from s to sec for clarity (#670) * Change monitoring url (#671) * Change monitoring url from monitoring_endpoints -> monitoring * Fixing details url to /monitoring/endpoint/ * Adding retry button on one message (#672) * Adding retry button on one message * Position retry btn * Showing the button only on hover * Changing the message to more generic * Filtering out system messages (#674) * Filtering out system messages * Applying coloring to units of graphed values (#673) * Applying coloring to units of graphed values * Adjust value and unit colors * Change hour abbreviation to hr * wraping custom check text (#683) * Add storing of group by in URL (#682) * Adding a toolbar that contains SC connectivity status (#677) * Adding a toolbar that contains information about connectivity to SC and SC Monitoring * footer stick to bottom and layout tweaking * further footer tweaks * remove version indicator from dashboard * Improve footer contrast * reverting changes to constant * Adding the connecting state to the toolbar * Changing to show toast errors once for connection error * Adding a code to check connectivity to SC Monitoring * Update src/ServicePulse.Host/app/modules/monitoring/js/directives/ui.particular.monitoringConnectivityStatus.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net> * Update src/ServicePulse.Host/app/modules/monitoring/js/services/services.monitoring.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net> * Change the method name, remove iterating through array * Rename vars * Sp installer con test buttons (#685) * test button for sc * check sc connectivity on button click * Show message boxes after sc connectivity check * connectivity check for sc monitoring * apply review fixes * more fixes * remove connectivity check from feature dlg next action * detect existing sp instance port (#678) * Fixing the bottom line to always show, and don't vanish (#687) * Pre release fixes (#686) * fix 1440px width in footer * Shrink heartbeats toggling warning * Emphasise connected status text * Fix tab focus indicator padding * changing styles a not depend on angular thingies * Bump version to 1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #445
@sergioc can you have a look on this one. I am not sure if you don't want to move the button a bit