Adding a toolbar that contains SC connectivity status #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergioc
changed the title
Contributor
|
@WojcikMike footer tweaked. However, the SC.Monitoring version indicator doesn't seem to always show in the Monitoring view. Not sure why. |
Contributor
Author
|
Looks good, I reverted your change to app.constants.js. With regards to not seeing this on some monitoring pages I have no idea. Could be some wierd cacheing issue. Still waiting for William to review before merging. |
Member
|
So it's not WIP anymore? |
Contributor
|
@WojcikMike during testing I didn't get any notifications when SP was unable to connect to SC(.monitoring). Is that to be expected? |
WojcikMike
changed the title
Contributor
Author
|
@WilliamBZA yes, it is not a WIP anymore. @sergioc could you be more specific? To see the status changed, go to monitoring pages and turn of SC Monitoring. The connectivity status is changed after failing to make a call to monitoring api. This kind of calls happen only on monitoring pages. |
sergioc
changed the title
WojcikMike
changed the title
Contributor
Author
|
And again ready to be reviewed |
WilliamBZA
reviewed
Nov 19, 2018
| <div> | ||
|
|
||
| <span> | ||
| <script>document.write(new Date().getFullYear())</script> © Particular Software |
...ulse.Host/app/modules/monitoring/js/directives/ui.particular.monitoringConnectivityStatus.js
Outdated
Show resolved
Hide resolved
src/ServicePulse.Host/app/modules/monitoring/js/services/services.monitoring.js
Outdated
Show resolved
Hide resolved
…particular.monitoringConnectivityStatus.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net>
…ces.monitoring.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net>
WojcikMike
pushed a commit
that referenced
this pull request
Nov 26, 2018
* Remove not needed dates in the large graph, and fix the scaleX when first series holds no values and second series does. * Fixing typo (#662) * Add tab to url (#666) * Adding information about which tab should be open to URL * Adding no data message when there is no messages processed (#667) * Making 0 line on graph always show (#668) * Min width 1440px (#669) * force min-width to 1440px * remove unnecessary !important * Change from s to sec for clarity (#670) * Change monitoring url (#671) * Change monitoring url from monitoring_endpoints -> monitoring * Fixing details url to /monitoring/endpoint/ * Adding retry button on one message (#672) * Adding retry button on one message * Position retry btn * Showing the button only on hover * Changing the message to more generic * Filtering out system messages (#674) * Filtering out system messages * Applying coloring to units of graphed values (#673) * Applying coloring to units of graphed values * Adjust value and unit colors * Change hour abbreviation to hr * wraping custom check text (#683) * Add storing of group by in URL (#682) * Adding a toolbar that contains SC connectivity status (#677) * Adding a toolbar that contains information about connectivity to SC and SC Monitoring * footer stick to bottom and layout tweaking * further footer tweaks * remove version indicator from dashboard * Improve footer contrast * reverting changes to constant * Adding the connecting state to the toolbar * Changing to show toast errors once for connection error * Adding a code to check connectivity to SC Monitoring * Update src/ServicePulse.Host/app/modules/monitoring/js/directives/ui.particular.monitoringConnectivityStatus.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net> * Update src/ServicePulse.Host/app/modules/monitoring/js/services/services.monitoring.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net> * Change the method name, remove iterating through array * Rename vars * Sp installer con test buttons (#685) * test button for sc * check sc connectivity on button click * Show message boxes after sc connectivity check * connectivity check for sc monitoring * apply review fixes * more fixes * remove connectivity check from feature dlg next action * detect existing sp instance port (#678) * Fixing the bottom line to always show, and don't vanish (#687) * Pre release fixes (#686) * fix 1440px width in footer * Shrink heartbeats toggling warning * Emphasise connected status text * Fix tab focus indicator padding * changing styles a not depend on angular thingies * Bump version to 1.15
WilliamBZA
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Remove not needed dates in the large graph, and fix the scaleX when first series holds no values and second series does. * Fixing typo (#662) * Add tab to url (#666) * Adding information about which tab should be open to URL * Adding no data message when there is no messages processed (#667) * Making 0 line on graph always show (#668) * Min width 1440px (#669) * force min-width to 1440px * remove unnecessary !important * Change from s to sec for clarity (#670) * Change monitoring url (#671) * Change monitoring url from monitoring_endpoints -> monitoring * Fixing details url to /monitoring/endpoint/ * Adding retry button on one message (#672) * Adding retry button on one message * Position retry btn * Showing the button only on hover * Changing the message to more generic * Filtering out system messages (#674) * Filtering out system messages * Applying coloring to units of graphed values (#673) * Applying coloring to units of graphed values * Adjust value and unit colors * Change hour abbreviation to hr * wraping custom check text (#683) * Add storing of group by in URL (#682) * Adding a toolbar that contains SC connectivity status (#677) * Adding a toolbar that contains information about connectivity to SC and SC Monitoring * footer stick to bottom and layout tweaking * further footer tweaks * remove version indicator from dashboard * Improve footer contrast * reverting changes to constant * Adding the connecting state to the toolbar * Changing to show toast errors once for connection error * Adding a code to check connectivity to SC Monitoring * Update src/ServicePulse.Host/app/modules/monitoring/js/directives/ui.particular.monitoringConnectivityStatus.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net> * Update src/ServicePulse.Host/app/modules/monitoring/js/services/services.monitoring.js Co-Authored-By: WojcikMike <michal.wojcik@particular.net> * Change the method name, remove iterating through array * Rename vars * Sp installer con test buttons (#685) * test button for sc * check sc connectivity on button click * Show message boxes after sc connectivity check * connectivity check for sc monitoring * apply review fixes * more fixes * remove connectivity check from feature dlg next action * detect existing sp instance port (#678) * Fixing the bottom line to always show, and don't vanish (#687) * Pre release fixes (#686) * fix 1440px width in footer * Shrink heartbeats toggling warning * Emphasise connected status text * Fix tab focus indicator padding * changing styles a not depend on angular thingies * Bump version to 1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #608
@sergioc please have a look as you might want to style it a bit. It looks good for me, but you might think differently.
@WilliamBZA can you have a look at SC Monitoring connectivity piece from the perspective of using RXjs and from the perspective of integrating toolbar that is part of shell and sc monitoring connectivity that is part of monitoring