Skip to content

Conversation

@mauroservienti
Copy link
Member

@mauroservienti mauroservienti commented May 21, 2019

ServicePulse uses the app.constants.js file to set default settings. Up to 1.19 the file is an AngularJs module, and thus it requires Angular to be loaded. The new connectionsManager on the other hand lives outside AngularJs as it is needed during the bootstrapping process to get license details from ServiceControl.

This PR:

  • changes the app.constants.js format to be non-Angular dependant
  • makes so that the app.constants.js simply sets a window variable with default configuration values, using the same structure as 1.19 (but outside of AngularJs)
  • makes so that the app.constants.js is loaded by Index.html as first script so that all the dependencies can find the values they expect where they expect them

At install time the installer collects information from the user about default URLs to use, and store them in memory. During the physical installation process the defined URLs are passed as command line arguments to ServicePulse.Host.exe that via the ExtractAndUpdateConstantsCommand:

  • extracts from resources the app.constants.js
  • sets the defined values
  • sets the current assembly version as ServicePulse version

This PR:

  • re-enables the installer screen(s) that allowed users to configure URLs
  • changes the ExtractAndUpdateConstantsCommand, that is responsible to write configured values, to update values using the new file format

Todo

Before merging

  • Test the installer (that is created by TC once this PR is compiled)

Once merged

@mauroservienti
Copy link
Member Author

tested, it works 😄

@mauroservienti
Copy link
Member Author

Particular/docs.particular.net@15d4308 reverted. Merging.

@mauroservienti mauroservienti merged commit 4f0f160 into allow-connectivity-config-via-webapp May 24, 2019
@mauroservienti mauroservienti deleted the existing-config-migration branch May 24, 2019 09:43
WilliamBZA pushed a commit that referenced this pull request Feb 17, 2023
WilliamBZA pushed a commit that referenced this pull request Feb 17, 2023
Add support to migrate existing URLs configuration and re-add support for URLs configuration in the installer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants