Add support to migrate existing URLs configuration and re-add support for URLs configuration in the installer #747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServicePulse uses the
app.constants.jsfile to set default settings. Up to 1.19 the file is an AngularJs module, and thus it requires Angular to be loaded. The newconnectionsManageron the other hand lives outside AngularJs as it is needed during the bootstrapping process to get license details from ServiceControl.This PR:
app.constants.jsformat to be non-Angular dependantapp.constants.jssimply sets awindowvariable with default configuration values, using the same structure as1.19(but outside of AngularJs)app.constants.jsis loaded byIndex.htmlas first script so that all the dependencies can find the values they expect where they expect themAt install time the installer collects information from the user about default URLs to use, and store them in memory. During the physical installation process the defined URLs are passed as command line arguments to ServicePulse.Host.exe that via the
ExtractAndUpdateConstantsCommand:app.constants.jsThis PR:
ExtractAndUpdateConstantsCommand, that is responsible to write configured values, to update values using the new file formatTodo
Before merging
Once merged