Skip to content

Fix broken link in monitoring endpoint details #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fix broken link in monitoring endpoint details #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/ServicePulse.Host/app/js/views/failed_messages/controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
var notifier = notifyService();

vm.selectedExceptionGroup = { 'id': $routeParams.groupId ? $routeParams.groupId : undefined, 'title': 'All Failed Messages', 'count': 0, 'initialLoad': true };
vm.selectedExceptionGroup.parentTitle = $routeParams.parentGroupId;
vm.selectedExceptionGroup.parentGroupIndex = $routeParams.parentGroupIndex;

if (!vm.selectedExceptionGroup.hasOwnProperty('title')) {
$location.path('/failed-messages/groups');
Expand Down
8 changes: 0 additions & 8 deletions src/ServicePulse.Host/app/js/views/failed_messages/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@
{
redirectTo: '/failed-messages/groups/:groupId'
})
.when('/failed-messages/groups/:parentGroupId/:parentGroupIndex/:groupId', {
data: {
pageTitle: 'Failed Messages'
},
templateUrl: 'js/views/failed_messages/view.html',
controller: 'failedMessagesController',
controllerAs: 'vm'
})
.when('/failed-messages/groups/:groupId', {
data: {
pageTitle: 'Failed Messages'
Expand Down
1 change: 0 additions & 1 deletion src/ServicePulse.Host/app/js/views/failed_messages/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
<div class="col-sm-12">
<div ng-show="!vm.selectedExceptionGroup.id" class="active">All failed messages ({{vm.failedMessages.length}} / {{vm.selectedExceptionGroup.count}} | number)</div>
<h1 ng-show="vm.selectedExceptionGroup.id" class="active break group-title">
<span ng-if="vm.selectedExceptionGroup.parentTitle">{{vm.selectedExceptionGroup.parentTitle}} - </span>
{{vm.selectedExceptionGroup.title}}
</h1>
<h3 class="active group-title group-message-count">{{vm.selectedExceptionGroup.count | number}} messages in group</h3>
Expand Down
4 changes: 2 additions & 2 deletions src/ServicePulse.Host/app/modules/monitoring/views/endpoint_details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ <h1 class="righ-side-ellipsis col-lg-max-10" uib-tooltip="{{endpointName}}">
<span class="warning" ng-if="endpoint.isScMonitoringDisconnected">
<i class="fa pa-monitoring-lost endpoint-details" uib-tooltip="Unable to connect to monitoring server"></i>
</span>
<a ng-if="endpoint.errorCount" class="warning" href="#/failed-messages/groups/{{endpointName}}/{{endpoint.serviceControlId}}">
<a ng-if="endpoint.errorCount" class="warning" href="#/failed-messages/groups/{{endpoint.serviceControlId}}">
<i class="fa fa-envelope" uib-tooltip="{{endpoint.errorCount | metricslargenumber}} failed messages associated with this endpoint. Click to see list."></i>
<span class="badge badge-important ng-binding">{{endpoint.errorCount | metricslargenumber}}</span>
</a>
Expand Down Expand Up @@ -271,7 +271,7 @@ <h5 ng-class="{active: showInstancesBreakdown}">
<i class="fa pa-endpoint-lost endpoint-details" uib-tooltip="Unable to connect to instance"></i>
</span>
<span class="warning" ng-if="instance.errorCount">
<a ng-if="instance.errorCount" class="warning btn" href="#/failed-messages/groups/{{endpointName}}/{{instance.serviceControlId}}">
<a ng-if="instance.errorCount" class="warning btn" href="#/failed-messages/groups/{{instance.serviceControlId}}">
<i class="fa fa-envelope" uib-tooltip="{{instance.errorCount | metricslargenumber}} failed messages associated with this endpoint. Click to see list."></i>
<span class="badge badge-important ng-binding">{{instance.errorCount | metricslargenumber}}</span>
</a>
Expand Down