Resolve directory traversal vulnerability in static file middleware #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janovesk
approved these changes
Mar 11, 2020
WojcikMike
reviewed
Mar 11, 2020
| middleware.Invoke(context); | ||
| Assert.AreEqual(("application/octet-stream"), context.Response.ContentType); | ||
| } | ||
| //[Test] |
Contributor
There was a problem hiding this comment.
@mikeminutillo @janovesk is there any reason that this test was not removed?
Member
Author
There was a problem hiding this comment.
The intention was to put something back in it's place after the security advisory was published. Maybe an approval test of all extensions in the assembly along with the mime-type or something.
WilliamBZA
pushed a commit
that referenced
this pull request
Feb 17, 2023
Resolve directory traversal vulnerability in static file middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the associated Security Advisory for more information.