Show ServiceControlUrl in error message when unable to connect #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WilliamBZA
approved these changes
Nov 18, 2020
|
Thanks @RC-787! |
sergioc
reviewed
Nov 18, 2020
Co-authored-by: Sergio <sergioc@users.noreply.github.com>
WojcikMike
pushed a commit
that referenced
this pull request
Nov 18, 2020
* replace absolute paths with relative (#985) Signed-off-by: Richard Lavey <richard.lavey@calastone.com> * Show ServiceControlUrl in error message when unable to connect (#983) * Show ServiceControlUrl in error message when unable to connect * Update src/ServicePulse.Host/app/js/views/sc_not_available.html Co-authored-by: Sergio <sergioc@users.noreply.github.com> Co-authored-by: Michał Wójcik <michal.wojcik@particular.net> Co-authored-by: Sergio <sergioc@users.noreply.github.com> Co-authored-by: Richard Lavey <richard.lavey@calastone.com> Co-authored-by: RC-787 <58704461+RC-787@users.noreply.github.com> Co-authored-by: Sergio <sergioc@users.noreply.github.com>
WilliamBZA
pushed a commit
that referenced
this pull request
Feb 17, 2023
* replace absolute paths with relative (#985) Signed-off-by: Richard Lavey <richard.lavey@calastone.com> * Show ServiceControlUrl in error message when unable to connect (#983) * Show ServiceControlUrl in error message when unable to connect * Update src/ServicePulse.Host/app/js/views/sc_not_available.html Co-authored-by: Sergio <sergioc@users.noreply.github.com> Co-authored-by: Michał Wójcik <michal.wojcik@particular.net> Co-authored-by: Sergio <sergioc@users.noreply.github.com> Co-authored-by: Richard Lavey <richard.lavey@calastone.com> Co-authored-by: RC-787 <58704461+RC-787@users.noreply.github.com> Co-authored-by: Sergio <sergioc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the string "put here the url we tried to connect to" is displayed as part of the error message that is shown when unable to connect to ServiceControl. This change shows the actual ServiceControlUrl