This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Moved EnableFileBasedRouting to routing config#18
Merged
Conversation
Contributor
Author
|
@Scooletz @timbussmann please review. |
timbussmann
reviewed
Dec 16, 2016
| { | ||
| config.GetSettings().Set(FileBasedRoutingFeature.RoutingFilePathKey, configurationFilePath); | ||
| config.EnableFeature<FileBasedRoutingFeature>(); | ||
| config.GetSettings().EnableFeatureByDefault<FileBasedRoutingFeature>(); |
Contributor
There was a problem hiding this comment.
what was the intent on switching to EnableFeatureByDefault?
Contributor
Author
There was a problem hiding this comment.
There is no EnableFeature on the settings.
Contributor
There was a problem hiding this comment.
ah I see, because we switched to RoutingSettings. It kinda looks like a "bug" then that EnableFeatureByDefault is available instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be consistent with other routing configuration methods e.g.
InstanceMappingFile.